mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tim Pepper <tpepper@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: Genapic cleanup & NUMAQ/es7000 removal
Date: Thu, 5 Feb 2009 08:15:34 -0800	[thread overview]
Message-ID: <eada2a070902050815h6ba682e2u158c4bb7c32f89ef@mail.gmail.com> (raw)
In-Reply-To: <1233310639-27916-1-git-send-email-andi@firstfloor.org>

On Fri, Jan 30, 2009 at 2:17 AM, Andi Kleen <andi@firstfloor.org> wrote:
> Just to demonstrate the clean up possibilities by removing es7000
> and numaq here's a sample patch series. It doesn't actually remove
> the es7000/numaq code, but just marks them broken and then
> removes all the hooks only used by them. I'm not actually sure
> I caught all the now unused hooks, there are probably now more.
> Also I think there's still some other NUMAQ only code in smpboot.c
> that could be exercised.
>
> This removes 6 hooks and 2 fields out of struct genapic (out of 26
> hooks, a reduction of ~23%!)
>
> The first three patches are independent cleanups that should
> be applied anyways.
>
> This gives a nice generic cleanup:


These look good to me for inclusion along with the big "x86: unify
genapic code, unify subarchitectures, remove old subarchitecture code"
series, or as Andi's indicated the initial cleanups themselves if the
other big set doesn't make the 2.6.30 for some reason.  For this
series:

Acked-by: Tim Pepper <lnxninja@linux.vnet.ibm.com>

  parent reply	other threads:[~2009-02-05 16:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 10:17 Andi Kleen
2009-01-30 10:17 ` [PATCH] Move wakeup_secondary_via_nmi into numaq_32.c Andi Kleen
2009-01-30 10:17   ` [PATCH] Remove empty setup_portio_remap inlines in bigsmp/summit Andi Kleen
2009-01-30 10:17     ` [PATCH] Mark NUMAQ broken Andi Kleen
2009-01-30 10:17       ` [PATCH] Mark ES7000 subarch broken Andi Kleen
2009-01-30 10:17         ` [PATCH] Remove store_NMI_vector in genapic Andi Kleen
2009-01-30 10:17           ` [PATCH] Remove smp_callin_clear_local_apic hook Andi Kleen
2009-01-30 10:17             ` [PATCH] Remove multi_timer_check Andi Kleen
2009-01-30 10:17               ` [PATCH] Remove setup_portio_remap Andi Kleen
2009-01-30 10:17                 ` [PATCH] Remove wakeup_cpu genapic vector Andi Kleen
2009-01-30 10:17                   ` [PATCH] Remove now unused default_update_genapic Andi Kleen
2009-01-30 10:17                     ` [PATCH] Remove trampoline_phys_low/high genapic fields Andi Kleen
2009-01-30 10:17                       ` [PATCH] Remove enable_apic_mode genapic hook Andi Kleen
2009-01-30 10:17                         ` [PATCH] Remove setup_ioapic_ids x86_quirks hook Andi Kleen
2009-02-05 16:15 ` Tim Pepper [this message]
2009-02-05 17:29   ` Genapic cleanup & NUMAQ/es7000 removal Ingo Molnar
2009-02-05 20:27     ` Andi Kleen
2009-02-05 21:25       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eada2a070902050815h6ba682e2u158c4bb7c32f89ef@mail.gmail.com \
    --to=tpepper@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®