* [PATCH] tags: fix config symbols generation
@ 2009-01-29 10:26 Alexey Dobriyan
2009-02-06 15:08 ` Pete Wyckoff
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2009-01-29 10:26 UTC (permalink / raw)
To: sam, akpm; +Cc: albcamus, linux-kernel
commit 4f628248a578585472e19e4cba2c604643af8c6c aka
"kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
breaks tags generation for Kconfig symbols.
Steps to reproduce:
make tags
vi -t PROC_FS
It should jump to 'config PROC_FS' line.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
scripts/tags.sh | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -76,7 +76,10 @@ all_sources()
all_kconfigs()
{
- find_sources $ALLSOURCE_ARCHS 'Kconfig*'
+ for arch in $ALLSOURCE_ARCHS; do
+ find_sources $arch 'Kconfig*'
+ done
+ find_other_sources 'Kconfig*'
}
all_defconfigs()
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tags: fix config symbols generation
2009-01-29 10:26 [PATCH] tags: fix config symbols generation Alexey Dobriyan
@ 2009-02-06 15:08 ` Pete Wyckoff
2009-02-06 17:22 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Pete Wyckoff @ 2009-02-06 15:08 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: sam, akpm, albcamus, linux-kernel
adobriyan@gmail.com wrote on Thu, 29 Jan 2009 13:26 +0300:
> commit 4f628248a578585472e19e4cba2c604643af8c6c aka
> "kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
> breaks tags generation for Kconfig symbols.
>
> Steps to reproduce:
>
> make tags
> vi -t PROC_FS
>
> It should jump to 'config PROC_FS' line.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> scripts/tags.sh | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -76,7 +76,10 @@ all_sources()
>
> all_kconfigs()
> {
> - find_sources $ALLSOURCE_ARCHS 'Kconfig*'
> + for arch in $ALLSOURCE_ARCHS; do
> + find_sources $arch 'Kconfig*'
> + done
> + find_other_sources 'Kconfig*'
> }
>
> all_defconfigs()
Yes, this is necessary. It fixes the problem introduced by
4f628248a578585472e19e4cba2c604643af8c6c (kbuild: reintroduce
ALLSOURCE_ARCHS support for tags/cscope).
Tested-by: Pete Wyckoff <pw@padd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tags: fix config symbols generation
2009-02-06 15:08 ` Pete Wyckoff
@ 2009-02-06 17:22 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2009-02-06 17:22 UTC (permalink / raw)
To: Pete Wyckoff; +Cc: Alexey Dobriyan, akpm, albcamus, linux-kernel
On Fri, Feb 06, 2009 at 07:08:58AM -0800, Pete Wyckoff wrote:
> adobriyan@gmail.com wrote on Thu, 29 Jan 2009 13:26 +0300:
> > commit 4f628248a578585472e19e4cba2c604643af8c6c aka
> > "kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
> > breaks tags generation for Kconfig symbols.
> >
> > Steps to reproduce:
> >
> > make tags
> > vi -t PROC_FS
> >
> > It should jump to 'config PROC_FS' line.
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > ---
> >
> > scripts/tags.sh | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > --- a/scripts/tags.sh
> > +++ b/scripts/tags.sh
> > @@ -76,7 +76,10 @@ all_sources()
> >
> > all_kconfigs()
> > {
> > - find_sources $ALLSOURCE_ARCHS 'Kconfig*'
> > + for arch in $ALLSOURCE_ARCHS; do
> > + find_sources $arch 'Kconfig*'
> > + done
> > + find_other_sources 'Kconfig*'
> > }
> >
> > all_defconfigs()
>
> Yes, this is necessary. It fixes the problem introduced by
> 4f628248a578585472e19e4cba2c604643af8c6c (kbuild: reintroduce
> ALLSOURCE_ARCHS support for tags/cscope).
>
> Tested-by: Pete Wyckoff <pw@padd.com>
Thanks for testing.
I'm heading for vacation in a few hours and has been busy at job due to this.
I will add this (and other pending stuff) to my kbuild-fixes.git tree
when I'm back.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-06 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-29 10:26 [PATCH] tags: fix config symbols generation Alexey Dobriyan
2009-02-06 15:08 ` Pete Wyckoff
2009-02-06 17:22 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®