* [PATCH 3/15] tridentfb: fix memory leaks in removal path
@ 2009-02-07 17:12 Andres Salomon
2009-02-08 14:34 ` [Linux-fbdev-devel] " Krzysztof Helt
0 siblings, 1 reply; 2+ messages in thread
From: Andres Salomon @ 2009-02-07 17:12 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-fbdev-devel, adaplas
We were leaking the cmap memory.
Signed-off-by: Andres Salomon <dilinger@debian.org>
---
drivers/video/tridentfb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/tridentfb.c b/drivers/video/tridentfb.c
index 479b2e7..c5369ba 100644
--- a/drivers/video/tridentfb.c
+++ b/drivers/video/tridentfb.c
@@ -1563,6 +1563,7 @@ static void __devexit trident_pci_remove(struct pci_dev *dev)
release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
pci_set_drvdata(dev, NULL);
kfree(info->pixmap.addr);
+ fb_dealloc_cmap(&info->cmap);
framebuffer_release(info);
}
--
1.5.6.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Linux-fbdev-devel] [PATCH 3/15] tridentfb: fix memory leaks in removal path
2009-02-07 17:12 [PATCH 3/15] tridentfb: fix memory leaks in removal path Andres Salomon
@ 2009-02-08 14:34 ` Krzysztof Helt
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Helt @ 2009-02-08 14:34 UTC (permalink / raw)
To: Andres Salomon; +Cc: Andrew Morton, linux-fbdev-devel, linux-kernel, adaplas
On Sat, 7 Feb 2009 12:12:33 -0500
Andres Salomon <dilinger@queued.net> wrote:
>
> We were leaking the cmap memory.
>
> Signed-off-by: Andres Salomon <dilinger@debian.org>
> ---
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> drivers/video/tridentfb.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/tridentfb.c b/drivers/video/tridentfb.c
> index 479b2e7..c5369ba 100644
> --- a/drivers/video/tridentfb.c
> +++ b/drivers/video/tridentfb.c
> @@ -1563,6 +1563,7 @@ static void __devexit trident_pci_remove(struct pci_dev *dev)
> release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
> pci_set_drvdata(dev, NULL);
> kfree(info->pixmap.addr);
> + fb_dealloc_cmap(&info->cmap);
> framebuffer_release(info);
> }
>
----------------------------------------------------------------------
Zostan mistrzem parkowania w Bombaju!
Zagraj >> http://link.interia.pl/f204e
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-08 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-07 17:12 [PATCH 3/15] tridentfb: fix memory leaks in removal path Andres Salomon
2009-02-08 14:34 ` [Linux-fbdev-devel] " Krzysztof Helt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome