* [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly
@ 2009-02-10 9:50 KOSAKI Motohiro
2009-02-10 11:00 ` Balbir Singh
0 siblings, 1 reply; 4+ messages in thread
From: KOSAKI Motohiro @ 2009-02-10 9:50 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki, Balbir Singh, LKML, linux-mm, Andrew Morton,
Rik van Riel, Lee Schermerhorn, Daisuke Nishimura
Cc: kosaki.motohiro
commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan:
split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().
but it isn't enough.
memcontrol.h header file still have legacy parts.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
---
include/linux/memcontrol.h | 6 ------
1 file changed, 6 deletions(-)
Index: b/include/linux/memcontrol.h
===================================================================
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -88,7 +88,6 @@ extern void mem_cgroup_end_migration(str
/*
* For memory reclaim.
*/
-extern long mem_cgroup_reclaim_imbalance(struct mem_cgroup *mem);
int mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg);
unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg,
struct zone *zone,
@@ -202,11 +201,6 @@ static inline void mem_cgroup_end_migrat
{
}
-static inline int mem_cgroup_reclaim_imbalance(struct mem_cgroup *mem)
-{
- return 0;
-}
-
static inline bool mem_cgroup_disabled(void)
{
return true;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly
2009-02-10 9:50 [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly KOSAKI Motohiro
@ 2009-02-10 11:00 ` Balbir Singh
2009-02-10 11:30 ` KOSAKI Motohiro
0 siblings, 1 reply; 4+ messages in thread
From: Balbir Singh @ 2009-02-10 11:00 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: KAMEZAWA Hiroyuki, LKML, linux-mm, Andrew Morton, Rik van Riel,
Lee Schermerhorn, Daisuke Nishimura
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-02-10 18:50:39]:
>
> commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan:
> split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().
>
> but it isn't enough.
> memcontrol.h header file still have legacy parts.
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> ---
> include/linux/memcontrol.h | 6 ------
> 1 file changed, 6 deletions(-)
>
The calc_mapped_ratio prototype should also be removed from this file.
--
Balbir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly
2009-02-10 11:00 ` Balbir Singh
@ 2009-02-10 11:30 ` KOSAKI Motohiro
2009-02-10 11:50 ` KOSAKI Motohiro
0 siblings, 1 reply; 4+ messages in thread
From: KOSAKI Motohiro @ 2009-02-10 11:30 UTC (permalink / raw)
To: balbir
Cc: kosaki.motohiro, KAMEZAWA Hiroyuki, LKML, linux-mm,
Andrew Morton, Rik van Riel, Lee Schermerhorn, Daisuke Nishimura
> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-02-10 18:50:39]:
>
> >
> > commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan:
> > split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().
> >
> > but it isn't enough.
> > memcontrol.h header file still have legacy parts.
> >
> >
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> > ---
> > include/linux/memcontrol.h | 6 ------
> > 1 file changed, 6 deletions(-)
> >
>
> The calc_mapped_ratio prototype should also be removed from this file.
ok, thanks.
I'll do that soon.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly
2009-02-10 11:30 ` KOSAKI Motohiro
@ 2009-02-10 11:50 ` KOSAKI Motohiro
0 siblings, 0 replies; 4+ messages in thread
From: KOSAKI Motohiro @ 2009-02-10 11:50 UTC (permalink / raw)
To: balbir
Cc: kosaki.motohiro, KAMEZAWA Hiroyuki, LKML, linux-mm,
Andrew Morton, Rik van Riel, Lee Schermerhorn, Daisuke Nishimura
Hi Balbir,
> > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-02-10 18:50:39]:
> >
> > >
> > > commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan:
> > > split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().
> > >
> > > but it isn't enough.
> > > memcontrol.h header file still have legacy parts.
> > >
> > >
> > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > > Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> > > ---
> > > include/linux/memcontrol.h | 6 ------
> > > 1 file changed, 6 deletions(-)
> > >
> >
> > The calc_mapped_ratio prototype should also be removed from this file.
>
> ok, thanks.
> I'll do that soon.
I fixed this by "memcg: remove mem_cgroup_calc_mapped_ratio() take2".
Then, We don't need to change this patch.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-02-10 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-10 9:50 [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly KOSAKI Motohiro
2009-02-10 11:00 ` Balbir Singh
2009-02-10 11:30 ` KOSAKI Motohiro
2009-02-10 11:50 ` KOSAKI Motohiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®