* [PATCH v2] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to unsigned long
@ 2009-02-14 23:10 Hannes Eder
2009-02-16 7:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2009-02-14 23:10 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-kernel, Jiri Slaby
Jiffies are unsigned long, make sure we fit in jiffies store variable
on archs with bits per long > 32.
Patch suggested by Jiri Slaby.
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
On Sat, Feb 14, 2009 at 11:48 PM, Jiri Slaby <jirislaby@gmail.com> wrote:
> Hannes Eder wrote:
>>...
>> -static u32 hfc_jiffies;
>> +static ulong hfc_jiffies;
>
> Ok, unsigned long would be nicer. I though it would be implicit when writing
> about ulong, but I see not in this uint-et-al context...
Uhm, it was not clear in this context, as uint is used all over the place.
Thank you Jiri.
Best,
Hannes
drivers/isdn/hardware/mISDN/hfcpci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 2bb85c4..641a9cd 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -57,7 +57,7 @@ static int HFC_cnt;
static uint debug;
static uint poll, tics;
static struct timer_list hfc_tl;
-static u32 hfc_jiffies;
+static unsigned long hfc_jiffies;
MODULE_AUTHOR("Karsten Keil");
MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to unsigned long
2009-02-14 23:10 [PATCH v2] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to unsigned long Hannes Eder
@ 2009-02-16 7:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-16 7:40 UTC (permalink / raw)
To: hannes; +Cc: netdev, kernel-janitors, linux-kernel, jirislaby
From: Hannes Eder <hannes@hanneseder.net>
Date: Sun, 15 Feb 2009 00:10:33 +0100
> Jiffies are unsigned long, make sure we fit in jiffies store variable
> on archs with bits per long > 32.
>
> Patch suggested by Jiri Slaby.
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Also applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-16 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-14 23:10 [PATCH v2] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to unsigned long Hannes Eder
2009-02-16 7:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®