Re: [PATCH] crypto: compress - Add pcomp interface

[Herbert Xu <herbert@gondor.apana.org.au>]

On Thu, Feb 12, 2009 at 04:19:40PM +0100, Geert Uytterhoeven wrote:
> On Tue, 10 Feb 2009, Herbert Xu wrote:
> > On Thu, Feb 05, 2009 at 05:24:51PM +0100, Geert Uytterhoeven wrote:
> > > > Well with the netlink parameters these can have variable lengths
> > > > depending on how many parameters the user supplies.
> > > 
> > > How can this be exported to userspace?
> > > How does this variable length parameter passing work? Do you have an example?
> > 
> > See how we use it for rtnetlink, e.g., in net/ipv4/ip_gre.c.
> > 
> > > Nothing in crypto/ seems to already use nla_*?
> > 
> > Well we don't have a user-space API yet :) But checkout the
> > discussions on this list.
> 
> I'm sorry, but this is a totally separate change, so I'm not going to do it
> right now.

Sorry but I disagree.  We're working on the user-space API right
now and having to redo the compression parameters API later because
we didn't take take user-space into account is just not acceptable.

In any case, the nla stuff is not as hard is it looks.  It's
going to add tens of lines to the setup code and that's it.

In order to get started, all you need to do is call nla_parse.
You don't even need a policy for the simple attributes.

Please let me know if you need more help in getting nla_parse
going.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt