Re: [PATCH] crypto: compress - Add pcomp interface

[Jaswinder Singh Rajput <jaswinderlinux@gmail.com>]

On Wed, Jan 14, 2009 at 10:24 PM, Geert Uytterhoeven
<Geert.Uytterhoeven@sonycom.com> wrote:
> On Wed, 14 Jan 2009, Jaswinder Singh Rajput wrote:
>> On Tue, Jan 13, 2009 at 9:29 PM, Geert Uytterhoeven
>> <Geert.Uytterhoeven@sonycom.com> wrote:
>> > +static inline struct pcomp_alg *crypto_pcomp_alg(struct crypto_pcomp *tfm)
>> > +{
>> > +       return __crypto_pcomp_alg(crypto_pcomp_tfm(tfm)->__crt_alg);
>> > +}
>> > +
>> > +static inline int crypto_pcomp_setup(struct crypto_pcomp *tfm,
>> > +                                    const void *params)
>> > +{
>> > +       return crypto_pcomp_alg(tfm)->setup(crypto_pcomp_tfm(tfm), params);
>> > +}
>> > +
>> > +static inline int crypto_pcomp_compress_init(struct crypto_pcomp *tfm)
>> > +{
>> > +       return crypto_pcomp_alg(tfm)->compress_init(crypto_pcomp_tfm(tfm));
>> > +}
>> > +
>> > +static inline int crypto_pcomp_compress_update(struct crypto_pcomp *tfm,
>> > +                                              struct comp_request *req)
>> > +{
>> > +       return crypto_pcomp_alg(tfm)->compress_update(crypto_pcomp_tfm(tfm),
>> > +                                                     req);
>> > +}
>> > +
>> > +static inline int crypto_pcomp_compress_final(struct crypto_pcomp *tfm,
>> > +                                             struct comp_request *req)
>> > +{
>> > +       return crypto_pcomp_alg(tfm)->compress_final(crypto_pcomp_tfm(tfm),
>> > +                                                    req);
>> > +}
>> > +
>> > +static inline int crypto_pcomp_decompress_init(struct crypto_pcomp *tfm)
>> > +{
>> > +       return crypto_pcomp_alg(tfm)->decompress_init(crypto_pcomp_tfm(tfm));
>> > +}
>> > +
>> > +static inline int crypto_pcomp_decompress_update(struct crypto_pcomp *tfm,
>> > +                                                struct comp_request *req)
>> > +{
>> > +       return crypto_pcomp_alg(tfm)->decompress_update(crypto_pcomp_tfm(tfm),
>> > +                                                       req);
>> > +}
>> > +
>> > +static inline int crypto_pcomp_decompress_final(struct crypto_pcomp *tfm,
>> > +                                               struct comp_request *req)
>> > +{
>> > +       return crypto_pcomp_alg(tfm)->decompress_final(crypto_pcomp_tfm(tfm),
>> > +                                                      req);
>> > +}
>>
>> Can you please use expressive but short names ?
>
> I admit they're quite long. But they're similar to the ones in use for the
> already existing crypto modules.
>

But I am expecting better results from you ;-)

Thanks
--
JSR