mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Eder <hannes@hanneseder.net>
To: netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/8] net/802: fix sparse warnings: context imbalance
Date: Wed, 25 Feb 2009 21:31:24 +0100	[thread overview]
Message-ID: <20090225203118.6251.34287.stgit@vmbox.hanneseder.net> (raw)
In-Reply-To: <20090225203012.6251.32002.stgit@vmbox.hanneseder.net>

Impact: Attribute function with __acquires(...) resp. __releases(...).

Fix this sparse warnings:
  net/802/tr.c:492:21: warning: context imbalance in 'rif_seq_start' - wrong count at exit
  net/802/tr.c:519:13: warning: context imbalance in 'rif_seq_stop' - unexpected unlock

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 net/802/tr.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/802/tr.c b/net/802/tr.c
index 158150f..dab6334 100644
--- a/net/802/tr.c
+++ b/net/802/tr.c
@@ -486,6 +486,7 @@ static struct rif_cache *rif_get_idx(loff_t pos)
 }
 
 static void *rif_seq_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&rif_lock)
 {
 	spin_lock_irq(&rif_lock);
 
@@ -517,6 +518,7 @@ static void *rif_seq_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void rif_seq_stop(struct seq_file *seq, void *v)
+	__releases(&rif_lock)
 {
 	spin_unlock_irq(&rif_lock);
 }


  reply	other threads:[~2009-02-25 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 20:31 [PATCH 0/8] net: fix (sparse) warnings Hannes Eder
2009-02-25 20:31 ` Hannes Eder [this message]
2009-02-25 20:31 ` [PATCH 2/8] 9p: fix sparse warning: cast adds address space Hannes Eder
2009-02-25 20:31 ` [PATCH 3/8] appletalk: fix warning: format not a string literal and no Hannes Eder
2009-02-25 20:32 ` [PATCH 4/8] [NET] sysctl: fix sparse warning: Should it be static? Hannes Eder
2009-02-25 20:32 ` [PATCH 5/8] decnet: fix sparse warnings: context imbalance Hannes Eder
2009-02-25 20:32 ` [PATCH 6/8] decnet: fix sparse warnings: symbol shadows an earlier one Hannes Eder
2009-02-25 20:32 ` [PATCH 7/8] inet fragments: fix sparse warning: context imbalance Hannes Eder
2009-02-25 20:33 ` [PATCH 8/8] wanrouter: fix sparse warnings: " Hannes Eder
2009-02-27  7:13 ` [PATCH 0/8] net: fix (sparse) warnings David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225203118.6251.34287.stgit@vmbox.hanneseder.net \
    --to=hannes@hanneseder.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®