mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Eder <hannes@hanneseder.net>
To: netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 7/8] inet fragments: fix sparse warning: context imbalance
Date: Wed, 25 Feb 2009 21:32:52 +0100	[thread overview]
Message-ID: <20090225203247.6251.30496.stgit@vmbox.hanneseder.net> (raw)
In-Reply-To: <20090225203012.6251.32002.stgit@vmbox.hanneseder.net>

Impact: Attribute function with __releases(...)

Fix this sparse warning:
  net/ipv4/inet_fragment.c:276:35: warning: context imbalance in 'inet_frag_find' - unexpected unlock

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 include/net/inet_frag.h  |    3 ++-
 net/ipv4/inet_fragment.c |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h
index e081eef..39f2dc9 100644
--- a/include/net/inet_frag.h
+++ b/include/net/inet_frag.h
@@ -61,7 +61,8 @@ void inet_frag_destroy(struct inet_frag_queue *q,
 				struct inet_frags *f, int *work);
 int inet_frag_evictor(struct netns_frags *nf, struct inet_frags *f);
 struct inet_frag_queue *inet_frag_find(struct netns_frags *nf,
-		struct inet_frags *f, void *key, unsigned int hash);
+		struct inet_frags *f, void *key, unsigned int hash)
+	__releases(&f->lock);
 
 static inline void inet_frag_put(struct inet_frag_queue *q, struct inet_frags *f)
 {
diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
index 6c52e08..eaf3e2c 100644
--- a/net/ipv4/inet_fragment.c
+++ b/net/ipv4/inet_fragment.c
@@ -267,6 +267,7 @@ static struct inet_frag_queue *inet_frag_create(struct netns_frags *nf,
 
 struct inet_frag_queue *inet_frag_find(struct netns_frags *nf,
 		struct inet_frags *f, void *key, unsigned int hash)
+	__releases(&f->lock)
 {
 	struct inet_frag_queue *q;
 	struct hlist_node *n;


  parent reply	other threads:[~2009-02-25 20:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 20:31 [PATCH 0/8] net: fix (sparse) warnings Hannes Eder
2009-02-25 20:31 ` [PATCH 1/8] net/802: fix sparse warnings: context imbalance Hannes Eder
2009-02-25 20:31 ` [PATCH 2/8] 9p: fix sparse warning: cast adds address space Hannes Eder
2009-02-25 20:31 ` [PATCH 3/8] appletalk: fix warning: format not a string literal and no Hannes Eder
2009-02-25 20:32 ` [PATCH 4/8] [NET] sysctl: fix sparse warning: Should it be static? Hannes Eder
2009-02-25 20:32 ` [PATCH 5/8] decnet: fix sparse warnings: context imbalance Hannes Eder
2009-02-25 20:32 ` [PATCH 6/8] decnet: fix sparse warnings: symbol shadows an earlier one Hannes Eder
2009-02-25 20:32 ` Hannes Eder [this message]
2009-02-25 20:33 ` [PATCH 8/8] wanrouter: fix sparse warnings: context imbalance Hannes Eder
2009-02-27  7:13 ` [PATCH 0/8] net: fix (sparse) warnings David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225203247.6251.30496.stgit@vmbox.hanneseder.net \
    --to=hannes@hanneseder.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®