From: Hannes Eder <hannes@hanneseder.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] sound/usb/usx2y: fix sparse warning: Should it be static?
Date: Wed, 25 Feb 2009 22:26:48 +0100 [thread overview]
Message-ID: <20090225212642.9226.10782.stgit@vmbox.hanneseder.net> (raw)
In-Reply-To: <20090225212551.9226.64699.stgit@vmbox.hanneseder.net>
Impact: Move declaration to header file.
Fix this sparse warning:
sound/usb/usx2y/usx2yhwdeppcm.c:739:5: warning: symbol 'usX2Y_hwdep_pcm_new' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
sound/usb/usx2y/usX2Yhwdep.c | 3 ---
sound/usb/usx2y/usx2yhwdeppcm.h | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c
index a26d8d8..4af8740 100644
--- a/sound/usb/usx2y/usX2Yhwdep.c
+++ b/sound/usb/usx2y/usX2Yhwdep.c
@@ -30,9 +30,6 @@
#include "usbusx2y.h"
#include "usX2Yhwdep.h"
-int usX2Y_hwdep_pcm_new(struct snd_card *card);
-
-
static int snd_us428ctls_vm_fault(struct vm_area_struct *area,
struct vm_fault *vmf)
{
diff --git a/sound/usb/usx2y/usx2yhwdeppcm.h b/sound/usb/usx2y/usx2yhwdeppcm.h
index c3382fd..9c4fb84 100644
--- a/sound/usb/usx2y/usx2yhwdeppcm.h
+++ b/sound/usb/usx2y/usx2yhwdeppcm.h
@@ -18,3 +18,5 @@ struct snd_usX2Y_hwdep_pcm_shm {
volatile unsigned captured_iso_frames;
int capture_iso_start;
};
+
+int usX2Y_hwdep_pcm_new(struct snd_card *card);
next prev parent reply other threads:[~2009-02-25 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 21:26 [PATCH 0/7] sound: fix sparse warnings Hannes Eder
2009-02-25 21:26 ` Hannes Eder [this message]
2009-02-25 21:28 ` [PATCH 2/7] sound/usb/usx2y: fix sparse warning: do-while statement is not a compound Hannes Eder
2009-02-25 21:28 ` [PATCH 3/7] sound/pci/hda: fix sparse warning: different signedness Hannes Eder
2009-02-25 21:28 ` [PATCH 4/7] sound/pci/emu10k1: " Hannes Eder
2009-02-25 21:29 ` [PATCH 5/7] sound/drivers/vx: " Hannes Eder
2009-02-25 21:29 ` [PATCH 6/7] sound/oss: fix sparse warnings: " Hannes Eder
2009-02-25 21:29 ` [PATCH 7/7] sound/oss: fix sparse warning: symbol shadows an earlier one Hannes Eder
2009-02-26 9:01 ` [PATCH 0/7] sound: fix sparse warnings Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225212642.9226.10782.stgit@vmbox.hanneseder.net \
--to=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®