mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Eder <hannes@hanneseder.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] sound/usb/usx2y: fix sparse warning: do-while statement is not a compound ...
Date: Wed, 25 Feb 2009 22:28:26 +0100	[thread overview]
Message-ID: <20090225212656.9226.49544.stgit@vmbox.hanneseder.net> (raw)
In-Reply-To: <20090225212551.9226.64699.stgit@vmbox.hanneseder.net>

Fix this sparse warning:
  sound/usb/usx2y/usbusx2y.c:231:33: warning: do-while statement is not a compound statement

Signed-off-by: Hannes Eder <hannes@hanneseder.net>

---

This patch generates a checkpatch.pl warning (line is 84 characters long), but
the formating of the entire file is so broken, the longest line is >150 chars long,
so I leave it as is.

 sound/usb/usx2y/usbusx2y.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c
index af8b849..5ce0da2 100644
--- a/sound/usb/usx2y/usbusx2y.c
+++ b/sound/usb/usx2y/usbusx2y.c
@@ -227,9 +227,9 @@ static void i_usX2Y_In04Int(struct urb *urb)
 	
 	if (usX2Y->US04) {
 		if (0 == usX2Y->US04->submitted)
-			do
+			do {
 				err = usb_submit_urb(usX2Y->US04->urb[usX2Y->US04->submitted++], GFP_ATOMIC);
-			while (!err && usX2Y->US04->submitted < usX2Y->US04->len);
+			} while (!err && usX2Y->US04->submitted < usX2Y->US04->len);
 	} else
 		if (us428ctls && us428ctls->p4outLast >= 0 && us428ctls->p4outLast < N_us428_p4out_BUFS) {
 			if (us428ctls->p4outLast != us428ctls->p4outSent) {


  parent reply	other threads:[~2009-02-25 21:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 21:26 [PATCH 0/7] sound: fix sparse warnings Hannes Eder
2009-02-25 21:26 ` [PATCH 1/7] sound/usb/usx2y: fix sparse warning: Should it be static? Hannes Eder
2009-02-25 21:28 ` Hannes Eder [this message]
2009-02-25 21:28 ` [PATCH 3/7] sound/pci/hda: fix sparse warning: different signedness Hannes Eder
2009-02-25 21:28 ` [PATCH 4/7] sound/pci/emu10k1: " Hannes Eder
2009-02-25 21:29 ` [PATCH 5/7] sound/drivers/vx: " Hannes Eder
2009-02-25 21:29 ` [PATCH 6/7] sound/oss: fix sparse warnings: " Hannes Eder
2009-02-25 21:29 ` [PATCH 7/7] sound/oss: fix sparse warning: symbol shadows an earlier one Hannes Eder
2009-02-26  9:01 ` [PATCH 0/7] sound: fix sparse warnings Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225212656.9226.49544.stgit@vmbox.hanneseder.net \
    --to=hannes@hanneseder.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®