* Re: [Patch] list usage cleanup in MISDN
@ 2009-02-16 8:05 Karsten Keil
2009-02-27 6:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Karsten Keil @ 2009-02-16 8:05 UTC (permalink / raw)
To: snakebyte; +Cc: linux-kernel, David Miller
Date: Fri, 13 Feb 2009 09:10:57 +0100
Trivial cleanup, list_del(); list_add_tail() is equivalent
to list_move_tail(). Semantic patch for coccinelle can be
found at www.cccmz.de/~snakebyte/list_move_tail.spatch
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Karsten Keil <kkeil@novell.com>
diff -u -p a/drivers/isdn/mISDN/timerdev.c b/drivers/isdn/mISDN/timerdev.c
--- a/drivers/isdn/mISDN/timerdev.c 2008-12-29 01:36:06.000000000 +0100
+++ b/drivers/isdn/mISDN/timerdev.c 2009-02-11 15:44:06.000000000 +0100
@@ -152,8 +152,7 @@ dev_expire_timer(unsigned long data)
u_long flags;
spin_lock_irqsave(&timer->dev->lock, flags);
- list_del(&timer->list);
- list_add_tail(&timer->list, &timer->dev->expired);
+ list_move_tail(&timer->list, &timer->dev->expired);
spin_unlock_irqrestore(&timer->dev->lock, flags);
wake_up_interruptible(&timer->dev->wait);
}
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch] list usage cleanup in MISDN
2009-02-16 8:05 [Patch] list usage cleanup in MISDN Karsten Keil
@ 2009-02-27 6:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-27 6:38 UTC (permalink / raw)
To: kkeil; +Cc: snakebyte, linux-kernel
From: Karsten Keil <kkeil@suse.de>
Date: Mon, 16 Feb 2009 09:05:21 +0100
> Trivial cleanup, list_del(); list_add_tail() is equivalent
> to list_move_tail(). Semantic patch for coccinelle can be
> found at www.cccmz.de/~snakebyte/list_move_tail.spatch
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
> Acked-by: Karsten Keil <kkeil@novell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-27 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-16 8:05 [Patch] list usage cleanup in MISDN Karsten Keil
2009-02-27 6:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®