From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC] introduce pr_cont macro
Date: Thu, 26 Feb 2009 04:03:15 +0100 [thread overview]
Message-ID: <20090226030315.GB7526@elte.hu> (raw)
In-Reply-To: <20090225205920.GA22091@localhost>
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> We cover all log-levels by pr_... macros except
> KERN_CONT one. Add it for convenience.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
>
> I think start printing with some pr_... macro
> and continue with printk(KERN_CONT ...) look
> not that clear -- better to continue with
> same pr_... slogan. Thoughts? I hope I didn't
> miss anything.
>
> include/linux/kernel.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6.git/include/linux/kernel.h
> ===================================================================
> --- linux-2.6.git.orig/include/linux/kernel.h
> +++ linux-2.6.git/include/linux/kernel.h
> @@ -370,6 +370,8 @@ static inline char *pack_hex_byte(char *
> printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
> #define pr_info(fmt, ...) \
> printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> +#define pr_cont(fmt, ...) \
> + printk(KERN_CONT pr_fmt(fmt), ##__VA_ARGS__)
Makes sense.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2009-02-26 3:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 20:59 Cyrill Gorcunov
2009-02-26 3:03 ` Ingo Molnar [this message]
2009-02-26 3:05 ` Harvey Harrison
2009-02-26 3:13 ` Ingo Molnar
2009-02-26 3:22 ` Harvey Harrison
2009-02-26 3:25 ` Ingo Molnar
2009-02-26 4:04 ` Cyrill Gorcunov
2009-02-26 5:25 ` Cyrill Gorcunov
2009-02-26 5:28 ` H. Peter Anvin
2009-02-26 6:51 ` Cyrill Gorcunov
2009-02-26 9:31 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226030315.GB7526@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®