mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Harvey Harrison <harvey.harrison@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] introduce pr_cont macro
Date: Thu, 26 Feb 2009 09:51:36 +0300	[thread overview]
Message-ID: <aa79d98a0902252251p4476fa83ndc2d3286e7b27094@mail.gmail.com> (raw)
In-Reply-To: <49A62899.4080001@zytor.com>

On Thu, Feb 26, 2009 at 8:28 AM, H. Peter Anvin <hpa@zytor.com> wrote:
> Ingo Molnar wrote:
>>
>> Btw., why do those macros use ##__VA_ARGS__ ? Why not a straightforward:
>>
>>  #define __pr_cont(args...) \
>>        printk(KERN_CONT args)
>>
>
> Don't know if anyone cares, but __VA_ARGS__ is C99 whereas args... is a gcc
> extension, AFAIK.
>
>        -hpa
>

I think in a sake of consistency better would be using __VA_ARGS__ here
too (since all prevous pr_...'s use it).

  reply	other threads:[~2009-02-26  6:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 20:59 Cyrill Gorcunov
2009-02-26  3:03 ` Ingo Molnar
2009-02-26  3:05   ` Harvey Harrison
2009-02-26  3:13     ` Ingo Molnar
2009-02-26  3:22       ` Harvey Harrison
2009-02-26  3:25         ` Ingo Molnar
2009-02-26  4:04           ` Cyrill Gorcunov
2009-02-26  5:25             ` Cyrill Gorcunov
2009-02-26  5:28           ` H. Peter Anvin
2009-02-26  6:51             ` Cyrill Gorcunov [this message]
2009-02-26  9:31             ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa79d98a0902252251p4476fa83ndc2d3286e7b27094@mail.gmail.com \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome