mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org
Cc: mm-commits@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com,
	balbir@linux.vnet.ibm.com, dhaval@linux.vnet.ibm.com,
	lizf@cn.fujitsu.cn, menage@google.com
Subject: Re: + cgroup-memcg-show-correct-file-mode.patch added to -mm tree
Date: Tue, 3 Mar 2009 08:58:28 +0100	[thread overview]
Message-ID: <20090303075828.GA10019@elte.hu> (raw)
In-Reply-To: <200902262100.n1QL0Vvi021877@imap1.linux-foundation.org>


* akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:

>  		.name = "usage_in_bytes",
>  		.private = MEMFILE_PRIVATE(_MEM, RES_USAGE),
>  		.read_u64 = mem_cgroup_read,
> +		.mode = 0444

Uhm, we've got symbols for permission bits for a reason. 
(S_IRUGO in this case)

> +		.mode = 0444

Ditto.

> +		.mode = 0200

Ditto. (S_IWUSR)

> +		.mode = 0444

Ditto.

	Ingo

       reply	other threads:[~2009-03-03  7:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200902262100.n1QL0Vvi021877@imap1.linux-foundation.org>
2009-03-03  7:58 ` Ingo Molnar [this message]
2009-03-04  0:26   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090303075828.GA10019@elte.hu \
    --to=mingo@elte.hu \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.cn \
    --cc=menage@google.com \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®