* Re: + cgroup-memcg-show-correct-file-mode.patch added to -mm tree [not found] <200902262100.n1QL0Vvi021877@imap1.linux-foundation.org> @ 2009-03-03 7:58 ` Ingo Molnar 2009-03-04 0:26 ` KAMEZAWA Hiroyuki 0 siblings, 1 reply; 2+ messages in thread From: Ingo Molnar @ 2009-03-03 7:58 UTC (permalink / raw) To: linux-kernel; +Cc: mm-commits, kamezawa.hiroyu, balbir, dhaval, lizf, menage * akpm@linux-foundation.org <akpm@linux-foundation.org> wrote: > .name = "usage_in_bytes", > .private = MEMFILE_PRIVATE(_MEM, RES_USAGE), > .read_u64 = mem_cgroup_read, > + .mode = 0444 Uhm, we've got symbols for permission bits for a reason. (S_IRUGO in this case) > + .mode = 0444 Ditto. > + .mode = 0200 Ditto. (S_IWUSR) > + .mode = 0444 Ditto. Ingo ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + cgroup-memcg-show-correct-file-mode.patch added to -mm tree 2009-03-03 7:58 ` + cgroup-memcg-show-correct-file-mode.patch added to -mm tree Ingo Molnar @ 2009-03-04 0:26 ` KAMEZAWA Hiroyuki 0 siblings, 0 replies; 2+ messages in thread From: KAMEZAWA Hiroyuki @ 2009-03-04 0:26 UTC (permalink / raw) To: Ingo Molnar; +Cc: linux-kernel, mm-commits, balbir, dhaval, lizf, menage On Tue, 3 Mar 2009 08:58:28 +0100 Ingo Molnar <mingo@elte.hu> wrote: > > * akpm@linux-foundation.org <akpm@linux-foundation.org> wrote: > > > .name = "usage_in_bytes", > > .private = MEMFILE_PRIVATE(_MEM, RES_USAGE), > > .read_u64 = mem_cgroup_read, > > + .mode = 0444 > > Uhm, we've got symbols for permission bits for a reason. > (S_IRUGO in this case) > > > + .mode = 0444 > > Ditto. > > > + .mode = 0200 > > Ditto. (S_IWUSR) > > > + .mode = 0444 > > Ditto. > ok, will post a replacement. Thank you for pointing out. -Kame > Ingo > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-04 0:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200902262100.n1QL0Vvi021877@imap1.linux-foundation.org>
2009-03-03 7:58 ` + cgroup-memcg-show-correct-file-mode.patch added to -mm tree Ingo Molnar
2009-03-04 0:26 ` KAMEZAWA Hiroyuki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®