From: Hannes Eder <hannes@hanneseder.net>
To: Felix Blyakher <felixb@sgi.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH 1/3] xfs: move declaration to header file
Date: Wed, 04 Mar 2009 19:33:48 +0100 [thread overview]
Message-ID: <20090304183331.525.4491.stgit@f10box.hanneseder.net> (raw)
In-Reply-To: <20090304183136.525.13769.stgit@f10box.hanneseder.net>
Fix this sparse warning:
fs/xfs/xfs_da_btree.c:1550:26: warning: symbol 'xfs_default_nameops' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
fs/xfs/xfs_da_btree.h | 1 +
fs/xfs/xfs_dir2.c | 2 --
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_da_btree.h b/fs/xfs/xfs_da_btree.h
index 9d5a7e8..41f27b3 100644
--- a/fs/xfs/xfs_da_btree.h
+++ b/fs/xfs/xfs_da_btree.h
@@ -268,5 +268,6 @@ xfs_daddr_t xfs_da_blkno(xfs_dabuf_t *dabuf);
extern struct kmem_zone *xfs_da_state_zone;
extern struct kmem_zone *xfs_dabuf_zone;
+extern const struct xfs_nameops xfs_default_nameops;
#endif /* __XFS_DA_BTREE_H__ */
diff --git a/fs/xfs/xfs_dir2.c b/fs/xfs/xfs_dir2.c
index 1afb122..c657bec 100644
--- a/fs/xfs/xfs_dir2.c
+++ b/fs/xfs/xfs_dir2.c
@@ -46,8 +46,6 @@
struct xfs_name xfs_name_dotdot = {"..", 2};
-extern const struct xfs_nameops xfs_default_nameops;
-
/*
* ASCII case-insensitive (ie. A-Z) support for directories that was
* used in IRIX.
next prev parent reply other threads:[~2009-03-04 18:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 18:33 [PATCH 0/3] xfs: fix sparse warnings Hannes Eder
2009-03-04 18:33 ` Hannes Eder [this message]
2009-03-05 13:37 ` [PATCH 1/3] xfs: move declaration to header file Christoph Hellwig
2009-03-04 18:34 ` [PATCH 2/3] xfs: make symbols static Hannes Eder
2009-03-05 13:38 ` Christoph Hellwig
2009-03-04 18:34 ` [PATCH 3/3] xfs: include header files for prototypes Hannes Eder
2009-03-05 13:39 ` Christoph Hellwig
2009-03-05 14:20 ` [PATCH 3/3 v2] " Hannes Eder
2009-03-05 21:29 ` Christoph Hellwig
2009-03-05 17:43 ` [PATCH 0/3] xfs: fix sparse warnings Felix Blyakher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304183331.525.4491.stgit@f10box.hanneseder.net \
--to=hannes@hanneseder.net \
--cc=felixb@sgi.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®