From: Christoph Hellwig <hch@lst.de>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Felix Blyakher <felixb@sgi.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/3] xfs: include header files for prototypes
Date: Thu, 5 Mar 2009 14:39:17 +0100 [thread overview]
Message-ID: <20090305133917.GC14854@lst.de> (raw)
In-Reply-To: <20090304183418.525.22262.stgit@f10box.hanneseder.net>
looks good, except for a tiny nit-pick:
> +++ b/fs/xfs/support/debug.c
> @@ -19,6 +19,7 @@
> #include "debug.h"
>
> /* xfs_mount.h drags a lot of crap in, sorry.. */
> +#include "xfs_error.h"
> #include "xfs_sb.h"
> #include "xfs_inum.h"
> #include "xfs_ag.h"
as xfs_mount.h doesn't require xfs_error.h it should be included
above that comment.
next prev parent reply other threads:[~2009-03-05 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 18:33 [PATCH 0/3] xfs: fix sparse warnings Hannes Eder
2009-03-04 18:33 ` [PATCH 1/3] xfs: move declaration to header file Hannes Eder
2009-03-05 13:37 ` Christoph Hellwig
2009-03-04 18:34 ` [PATCH 2/3] xfs: make symbols static Hannes Eder
2009-03-05 13:38 ` Christoph Hellwig
2009-03-04 18:34 ` [PATCH 3/3] xfs: include header files for prototypes Hannes Eder
2009-03-05 13:39 ` Christoph Hellwig [this message]
2009-03-05 14:20 ` [PATCH 3/3 v2] " Hannes Eder
2009-03-05 21:29 ` Christoph Hellwig
2009-03-05 17:43 ` [PATCH 0/3] xfs: fix sparse warnings Felix Blyakher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305133917.GC14854@lst.de \
--to=hch@lst.de \
--cc=felixb@sgi.com \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome