mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Change %Z to %z in printf
@ 2009-03-07 18:54 Jan Engelhardt
  2009-03-07 22:59 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2009-03-07 18:54 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: David Miller

Hi,


I found out that %Z is actually a deprecated libc5-ism as printf(3) of 
man-pages 3.17 dated 2008-12-19 tells me.

In ${kernel}/lib/vsprintf.c, I find the following note and wondered
if there might be any objections to going back to 'z'.

        int qualifier;          /* 'h', 'l', or 'L' for integer fields */ 
                                /* 'z' support added 23/7/1999 S.H.    */ 
                                /* 'z' changed to 'Z' --davidm 1/25/99 */ 
                                /* 't' added for ptrdiff_t */ 


Jan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Change %Z to %z in printf
  2009-03-07 18:54 Change %Z to %z in printf Jan Engelhardt
@ 2009-03-07 22:59 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-03-07 22:59 UTC (permalink / raw)
  To: jengelh; +Cc: linux-kernel

From: Jan Engelhardt <jengelh@medozas.de>
Date: Sat, 7 Mar 2009 19:54:45 +0100 (CET)

> I found out that %Z is actually a deprecated libc5-ism as printf(3) of 
> man-pages 3.17 dated 2008-12-19 tells me.
> 
> In ${kernel}/lib/vsprintf.c, I find the following note and wondered
> if there might be any objections to going back to 'z'.

GCC's printf formatting checks only started recognizing %z a few
releases ago.  We kept the %Z in there so that with all gcc versions
we won't get warnings.

We've recently increased the minimal GCC version, so going to %z might
be OK now.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-07 23:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-07 18:54 Change %Z to %z in printf Jan Engelhardt
2009-03-07 22:59 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®