* Re: [Linux-fbdev-devel] [PATCH] omapfb: Fix argument of blank operation.
[not found] <1228430755-4221-1-git-send-email-felipe.contreras@gmail.com>
@ 2009-03-11 17:17 ` Trilok Soni
2009-03-11 22:20 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Trilok Soni @ 2009-03-11 17:17 UTC (permalink / raw)
To: Felipe Contreras
Cc: linux-fbdev-devel, linux-omap, Felipe Contreras, linux-kernel,
Andrew Morton
Hi Felipe,
On Fri, Dec 5, 2008 at 4:15 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> From: Felipe Contreras <felipe.contreras@nokia.com>
>
> The blank operation should receive FB_BLANK_POWERDOWN, not
> VESA_POWERDOWN.
>
Thanks. Looks good.
Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Linux-fbdev-devel] [PATCH] omapfb: Fix argument of blank operation.
2009-03-11 17:17 ` [Linux-fbdev-devel] [PATCH] omapfb: Fix argument of blank operation Trilok Soni
@ 2009-03-11 22:20 ` Andrew Morton
2009-03-11 22:43 ` Felipe Contreras
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2009-03-11 22:20 UTC (permalink / raw)
To: Trilok Soni
Cc: felipe.contreras, linux-fbdev-devel, linux-omap,
felipe.contreras, linux-kernel
On Wed, 11 Mar 2009 22:47:41 +0530
Trilok Soni <soni.trilok@gmail.com> wrote:
> Hi Felipe,
>
> On Fri, Dec 5, 2008 at 4:15 AM, Felipe Contreras
I bet he thought we'd forgotten.
> <felipe.contreras@gmail.com> wrote:
> > From: Felipe Contreras <felipe.contreras@nokia.com>
> >
> > The blank operation should receive FB_BLANK_POWERDOWN, not
> > VESA_POWERDOWN.
> >
>
> Thanks. Looks good.
>
> Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
>
Unfortunately the changelog didn't give me any hint as to the
seriousness of the problem which was fixed. So I queued it for 2.6.30,
perhaps inappropriately.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Linux-fbdev-devel] [PATCH] omapfb: Fix argument of blank operation.
2009-03-11 22:20 ` Andrew Morton
@ 2009-03-11 22:43 ` Felipe Contreras
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Contreras @ 2009-03-11 22:43 UTC (permalink / raw)
To: Andrew Morton
Cc: Trilok Soni, linux-fbdev-devel, linux-omap, felipe.contreras,
linux-kernel
On Thu, Mar 12, 2009 at 12:20 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Wed, 11 Mar 2009 22:47:41 +0530
> Trilok Soni <soni.trilok@gmail.com> wrote:
>
>> Hi Felipe,
>>
>> On Fri, Dec 5, 2008 at 4:15 AM, Felipe Contreras
>
> I bet he thought we'd forgotten.
You bet correctly :)
>> <felipe.contreras@gmail.com> wrote:
>> > From: Felipe Contreras <felipe.contreras@nokia.com>
>> >
>> > The blank operation should receive FB_BLANK_POWERDOWN, not
>> > VESA_POWERDOWN.
>> >
>>
>> Thanks. Looks good.
>>
>> Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
>>
>
> Unfortunately the changelog didn't give me any hint as to the
> seriousness of the problem which was fixed. So I queued it for 2.6.30,
> perhaps inappropriately.
I noticed because of another bug in omapfb which required blanking in
order to actually see something (PM stuff?). If user-space tries to
blank the usual way, it wouldn't work.
My guess is that it's not a big issue, in part because nobody has
noticed, but perhaps I'm wrong. I was hoping the fbdev guys would know
better.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-11 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1228430755-4221-1-git-send-email-felipe.contreras@gmail.com>
2009-03-11 17:17 ` [Linux-fbdev-devel] [PATCH] omapfb: Fix argument of blank operation Trilok Soni
2009-03-11 22:20 ` Andrew Morton
2009-03-11 22:43 ` Felipe Contreras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®