From: Ingo Molnar <mingo@elte.hu>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Mike Travis <travis@sgi.com>
Subject: Re: [PULL] x86 cpumask work
Date: Tue, 17 Mar 2009 11:51:21 +0100 [thread overview]
Message-ID: <20090317105121.GJ6477@elte.hu> (raw)
In-Reply-To: <200903171450.34549.rusty@rustcorp.com.au>
* Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Monday 16 March 2009 19:18:02 Ingo Molnar wrote:
> >
> > * Rusty Russell <rusty@rustcorp.com.au> wrote:
> > > As the comments says, it can only be NULL during boot of the first CPU.
> > >
> > > start_kernel -> check_bugs -> identify_boot_cpu -> identify_cpu
> > > -> select_idle_routine.
> > >
> > > Did you want me to panic if it fails?
> >
> > Ah, ok. But i think it's very unobvious to embedd a "once per
> > bootup" dynamic allocation like that. Please put it into a
> > separate init routine instead. That way select_idle() [which
> > runs during every CPU hotplug event] wont have this allocation.
>
> There wasn't an obvious place to put the init; I've created one.
>
> How's this?
looks perfect. Should i apply or do you want to send a pull
request?
Ingo
next prev parent reply other threads:[~2009-03-17 10:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 4:23 Rusty Russell
2009-03-12 10:26 ` Ingo Molnar
2009-03-12 10:37 ` Ingo Molnar
2009-03-12 22:54 ` Rusty Russell
2009-03-13 0:57 ` Ingo Molnar
2009-03-13 2:46 ` Rusty Russell
2009-03-13 3:20 ` Ingo Molnar
2009-03-13 4:34 ` Rusty Russell
2009-03-13 4:55 ` Ingo Molnar
2009-03-13 5:27 ` Ingo Molnar
2009-03-13 5:32 ` Ingo Molnar
2009-03-13 6:44 ` Rusty Russell
2009-03-13 13:12 ` Rusty Russell
2009-03-13 13:45 ` [tip:cpus4096] cpumask: convert node_to_cpumask_map[] to cpumask_var_t Rusty Russell
2009-03-13 15:27 ` [PULL] x86 cpumask work Ingo Molnar
2009-03-15 2:56 ` Rusty Russell
2009-03-15 6:00 ` Ingo Molnar
2009-03-16 3:03 ` Rusty Russell
2009-03-16 8:48 ` Ingo Molnar
2009-03-17 4:20 ` Rusty Russell
2009-03-17 10:51 ` Ingo Molnar [this message]
2009-03-17 21:27 ` Rusty Russell
2009-03-18 8:51 ` [tip:cpus4096] cpumask: fix CONFIG_CPUMASK_OFFSTACK=y cpu hotunplug crash Rusty Russell
2009-03-13 13:13 ` [PATCH] Move numa_node_id default implementation to topology.h Rusty Russell
2009-03-13 13:45 ` [tip:cpus4096] numa, cpumask: move " Rusty Russell
2009-03-17 18:56 [PULL] x86 cpumask work Cliff Wickman
2009-03-17 21:52 ` Rusty Russell
2009-03-18 12:57 ` Cliff Wickman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317105121.GJ6477@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®