[PATCH] crypto/scatterwalk.c to skip unnecessary flush_dcache_page() calls which may cause kernel panic

[PATCH] crypto/scatterwalk.c to skip unnecessary flush_dcache_page() calls which may cause kernel panic

[Chung-Yih Wang (王崇懿)]

I am developing the ipsec tools on ARM platform. When I turn the
 CONFIG_DEBUG_VM on, the ipsec traffic triggers the kernel panic
which is caused by the VM_DEBUG_ON(PageSlab(page)) of
page_mapping() in the call of flush_dcache_page().

The root cause is that ipsec/esp intends to encrypt the original
data and dynamically allocate cache memory in socket buffer for
this purpose. However, all the cache memory pages dynamically
allocated in socket buffer will be flagged as PG_slab by
__SetPageSlab(). That's the reason it asserts on
VM_BUG_ON(PageSlab(page)) in flush_dcache_page(). Since the
flush_dcache_page() is to ensure the cache coherency between
kernel mapping and userspace mapping. The kernel cache memory
created in socket buffer for encrypting ipsec traffic does not
need to call this function at all since it is all kernel space
data.

Below is my patch for fixing this bug for  CONFIG_DEBUG_VM=y.

Chung-yih


diff --git a/crypto/scatterwalk.c b/crypto/scatterwalk.c
index 9aeeb52..3de89a4 100644
--- a/crypto/scatterwalk.c
+++ b/crypto/scatterwalk.c
@@ -54,7 +54,8 @@ static void scatterwalk_pagedone(struct scatter_walk
*walk, int out,
                struct page *page;

                page = sg_page(walk->sg) + ((walk->offset - 1) >> PAGE_SHIFT);
-               flush_dcache_page(page);
+               if (!PageSlab(page))
+                       flush_dcache_page(page);
        }

        if (more) {

Re: [PATCH] crypto/scatterwalk.c to skip unnecessary flush_dcache_page() calls which may cause kernel panic

[David Miller]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=big5, Size: 399 bytes --]

From: Chung-Yih Wang (¤ý±RÅt) <cywang@google.com>
Date: Fri, 20 Mar 2009 16:15:16 +0800

> Below is my patch for fixing this bug for  CONFIG_DEBUG_VM=y.

This exact change is already in the tree, and it's been there
for at least a month.

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] crypto/scatterwalk.c to skip unnecessary flush_dcache_page() calls which may cause kernel panic

[Chung-Yih Wang (王崇懿)]

That's great. Thanks for the info.

2009/3/20 David Miller <davem@davemloft.net>:
> From: Chung-Yih Wang (王崇懿) <cywang@google.com>
> Date: Fri, 20 Mar 2009 16:15:16 +0800
>
>> Below is my patch for fixing this bug for  CONFIG_DEBUG_VM=y.
>
> This exact change is already in the tree, and it's been there
> for at least a month.
>
>