mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus@drzeus.cx>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: MMC layer regression with single-block controllers
Date: Tue, 24 Mar 2009 21:01:38 +0100	[thread overview]
Message-ID: <20090324210138.71029c2c@mjolnir.ossman.eu> (raw)
In-Reply-To: <20090323092802.GA30122@roarinelk.homelinux.net>

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On Mon, 23 Mar 2009 10:28:02 +0100
Manuel Lauss <mano@roarinelk.homelinux.net> wrote:

> Hello Pierre,
> 
> Since about 2.6.28-rc1, I hit the following BUG_ON() in mmc/core.c
> (line 155):
> 
>         if (mrq->data) {
>                 BUG_ON(mrq->data->blksz > host->max_blk_size);
> >>>>>>>>>       BUG_ON(mrq->data->blocks > host->max_blk_count);  <<<<<<
>                 BUG_ON(mrq->data->blocks * mrq->data->blksz >
>                         host->max_req_size);
> 
> It's easy to reproduce; just set your favorite host controllers'
> mmc->max_blk_cnt to 1 (or anything smaller than 4).  As far as I can
> tell it was introduced with some block layer changes before 2.6.28-rc1
> was released.
> 

Ouch. Have you determined that it is the block layer that isn't
respecting its settings? If so, the we probably need to notify Jens
Axboe.

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2009-03-24 20:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23  9:28 Manuel Lauss
2009-03-24 20:01 ` Pierre Ossman [this message]
2009-03-25 10:48   ` Manuel Lauss
2009-03-25 11:04     ` Jens Axboe
2009-03-25 11:36       ` Pierre Ossman
2009-03-25 11:42         ` Jens Axboe
2009-03-25 15:53           ` Pierre Ossman
2009-03-25 16:14             ` Jens Axboe
2009-03-25 16:24               ` Pierre Ossman
2009-03-25 17:43                 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090324210138.71029c2c@mjolnir.ossman.eu \
    --to=drzeus@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mano@roarinelk.homelinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®