* [PATCH]: Fix sparc64 build.
@ 2009-03-26 23:44 David Miller
2009-03-27 0:16 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2009-03-26 23:44 UTC (permalink / raw)
To: torvalds; +Cc: mingo, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=utf-8, Size: 1157 bytes --]
Ingo, didn't we fix this (a few times)? :-)
Linus, please apply:
sparc64: Fix build of timer_interrupt().
arch/sparc/kernel/time_64.c: In function âtimer_interruptâ:
arch/sparc/kernel/time_64.c:732: error: âstruct kernel_statâ has no member named âirqsâ
make[1]: *** [arch/sparc/kernel/time_64.o] Error 1
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/arch/sparc/kernel/time_64.c b/arch/sparc/kernel/time_64.c
index 642562d..4ee2e48 100644
--- a/arch/sparc/kernel/time_64.c
+++ b/arch/sparc/kernel/time_64.c
@@ -724,12 +724,14 @@ void timer_interrupt(int irq, struct pt_regs *regs)
unsigned long tick_mask = tick_ops->softint_mask;
int cpu = smp_processor_id();
struct clock_event_device *evt = &per_cpu(sparc64_events, cpu);
+ struct irq_desc *desc;
clear_softint(tick_mask);
irq_enter();
- kstat_this_cpu.irqs[0]++;
+ desc = irq_to_desc(0);
+ kstat_incr_irqs_this_cpu(0, desc);
if (unlikely(!evt->event_handler)) {
printk(KERN_WARNING
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]: Fix sparc64 build.
2009-03-26 23:44 [PATCH]: Fix sparc64 build David Miller
@ 2009-03-27 0:16 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-03-27 0:16 UTC (permalink / raw)
To: David Miller; +Cc: torvalds, linux-kernel, Thomas Gleixner
* David Miller <davem@davemloft.net> wrote:
>
> Ingo, didn't we fix this (a few times)? :-)
>
> Linus, please apply:
>
> sparc64: Fix build of timer_interrupt().
>
> arch/sparc/kernel/time_64.c: In function ‘timer_interrupt’:
> arch/sparc/kernel/time_64.c:732: error: ‘struct kernel_stat’ has no member named ‘irqs’
> make[1]: *** [arch/sparc/kernel/time_64.o] Error 1
Oops, sorry! Note that the fix is in a pending pull request (but
this still does not make it right that i cut trees with this not in
it).
I did check sparc for that particular pull request:
aldebaran:~/linux/linux> ./m-arch-all
[...]
testing sparc: -git: pass ( 2), -tip: pass ( 2)
So once the pieces are together again, it should all be fine.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-27 0:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-26 23:44 [PATCH]: Fix sparc64 build David Miller
2009-03-27 0:16 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®