* bug in drivers/edac/edac_core.h pci_write_bits32()
@ 2009-03-26 23:54 Jeff Haran
2009-04-06 4:46 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Haran @ 2009-03-26 23:54 UTC (permalink / raw)
To: linux-kernel
2.6.29 and previous versions seem to contain this bug which I found just
eyeballing the code:
static inline void pci_write_bits32(struct pci_dev *pdev, int offset,
u32 value, u32 mask)
{
if (mask != 0xffff) {
u32 buf;
pci_read_config_dword(pdev, offset, &buf);
value &= mask;
buf &= ~mask;
value |= buf;
}
pci_write_config_dword(pdev, offset, value);
}
I'm pretty sure that "if" statement should be:
if (mask != 0xffffffff) {
Please copy my email address in any response as I do not subscribe.
Thanks,
Jeff Haran
Brocade
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: bug in drivers/edac/edac_core.h pci_write_bits32()
2009-03-26 23:54 bug in drivers/edac/edac_core.h pci_write_bits32() Jeff Haran
@ 2009-04-06 4:46 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2009-04-06 4:46 UTC (permalink / raw)
To: Jeff Haran; +Cc: linux-kernel, Doug Thompson
(cc maintainer)
On Thu, 26 Mar 2009 16:54:01 -0700 "Jeff Haran" <jharan@Brocade.COM> wrote:
> 2.6.29 and previous versions seem to contain this bug which I found just
> eyeballing the code:
>
> static inline void pci_write_bits32(struct pci_dev *pdev, int offset,
> u32 value, u32 mask)
> {
> if (mask != 0xffff) {
> u32 buf;
>
> pci_read_config_dword(pdev, offset, &buf);
> value &= mask;
> buf &= ~mask;
> value |= buf;
> }
>
> pci_write_config_dword(pdev, offset, value);
> }
>
> I'm pretty sure that "if" statement should be:
>
> if (mask != 0xffffffff) {
>
> Please copy my email address in any response as I do not subscribe.
>
> Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-06 4:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-26 23:54 bug in drivers/edac/edac_core.h pci_write_bits32() Jeff Haran
2009-04-06 4:46 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®