mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH 25/27] symbol: Remove various bits of left over junk
Date: Mon, 06 Apr 2009 17:35:25 +0100	[thread overview]
Message-ID: <20090406163517.12934.81586.stgit@t61.ukuu.org.uk> (raw)
In-Reply-To: <20090406162959.12934.97904.stgit@t61.ukuu.org.uk>

There are various bits of code here that are unfinished and instead of
being harmless either confuse or spew stuff into the logs at higher than
debug level. They can and should go away.

Also remove the bogus use of tty->lowlatency. We fixed the need for this hack
long ago (with the flip buffer rewrite) but people keep copying it into drivers.

Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
---

 drivers/usb/serial/symbolserial.c |   67 -------------------------------------
 1 files changed, 0 insertions(+), 67 deletions(-)


diff --git a/drivers/usb/serial/symbolserial.c b/drivers/usb/serial/symbolserial.c
index 8b3cbc8..69879e4 100644
--- a/drivers/usb/serial/symbolserial.c
+++ b/drivers/usb/serial/symbolserial.c
@@ -139,14 +139,6 @@ static int symbol_open(struct tty_struct *tty, struct usb_serial_port *port,
 	priv->port = port;
 	spin_unlock_irqrestore(&priv->lock, flags);
 
-	/*
-	 * Force low_latency on so that our tty_push actually forces the data
-	 * through, otherwise it is scheduled, and with high data rates (like
-	 * with OHCI) data can get lost.
-	 */
-	if (tty)
-		tty->low_latency = 1;
-
 	/* Start reading from the device */
 	usb_fill_int_urb(priv->int_urb, priv->udev,
 			 usb_rcvintpipe(priv->udev, priv->int_address),
@@ -205,62 +197,6 @@ static void symbol_unthrottle(struct tty_struct *tty)
 							__func__, result);
 }
 
-static int symbol_ioctl(struct tty_struct *tty, struct file *file,
-			unsigned int cmd, unsigned long arg)
-{
-	struct usb_serial_port *port = tty->driver_data;
-	struct device *dev = &port->dev;
-
-	/*
-	 * Right now we need to figure out what commands
-	 * most userspace tools want to see for this driver,
-	 * so just log the things.
-	 */
-	switch (cmd) {
-	case TIOCSERGETLSR:
-		dev_info(dev, "%s: TIOCSERGETLSR\n", __func__);
-		break;
-
-	case TIOCGSERIAL:
-		dev_info(dev, "%s: TIOCGSERIAL\n", __func__);
-		break;
-
-	case TIOCMIWAIT:
-		dev_info(dev, "%s: TIOCMIWAIT\n", __func__);
-		break;
-
-	case TIOCGICOUNT:
-		dev_info(dev, "%s: TIOCGICOUNT\n", __func__);
-		break;
-	default:
-		dev_info(dev, "%s: unknown (%d)\n", __func__, cmd);
-	}
-	return -ENOIOCTLCMD;
-}
-
-static int symbol_tiocmget(struct tty_struct *tty, struct file *file)
-{
-	struct usb_serial_port *port = tty->driver_data;
-	struct device *dev = &port->dev;
-
-	/* TODO */
-	/* probably just need to shadow whatever was sent to us here */
-	dev_info(dev, "%s\n", __func__);
-	return 0;
-}
-
-static int symbol_tiocmset(struct tty_struct *tty, struct file *file,
-			   unsigned int set, unsigned int clear)
-{
-	struct usb_serial_port *port = tty->driver_data;
-	struct device *dev = &port->dev;
-
-	/* TODO */
-	/* probably just need to shadow whatever was sent to us here */
-	dev_info(dev, "%s\n", __func__);
-	return 0;
-}
-
 static int symbol_startup(struct usb_serial *serial)
 {
 	struct symbol_private *priv;
@@ -367,9 +303,6 @@ static struct usb_serial_driver symbol_device = {
 	.shutdown =		symbol_shutdown,
 	.throttle = 		symbol_throttle,
 	.unthrottle =		symbol_unthrottle,
-	.ioctl = 		symbol_ioctl,
-	.tiocmget = 		symbol_tiocmget,
-	.tiocmset = 		symbol_tiocmset,
 };
 
 static int __init symbol_init(void)


  parent reply	other threads:[~2009-04-06 15:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 16:31 [RESEND PATCH 00/27] Serial updates for 2.6.30 Alan Cox
2009-04-06 16:31 ` [PATCH 01/27] 8250_pnp.c: add another Wacom tablet Alan Cox
2009-04-06 16:32 ` [PATCH 02/27] serial: Update PNP IDs Alan Cox
2009-04-06 16:32 ` [PATCH 03/27] 8250_pci: add support for National Instruments 843x RS232 devices Alan Cox
2009-04-06 16:32 ` [PATCH 04/27] 8250_pci: add support for National Instruments legacy 8420 RS232 boards Alan Cox
2009-04-06 16:32 ` [PATCH 05/27] blackfin: BF538/9 serial uart support Alan Cox
2009-04-06 16:32 ` [PATCH 06/27] blackfin: Use unsigned long for flags with irq functions Alan Cox
2009-04-06 16:32 ` [PATCH 07/27] blackfin: Fix tty compile error in PIO mode Alan Cox
2009-04-06 16:32 ` [PATCH 08/27] Fix DMA rx ring buffer handling Alan Cox
2009-04-06 16:32 ` [PATCH 09/27] blackfin: Subtract ANOMALY_05000230 on quot Alan Cox
2009-04-06 16:32 ` [PATCH 10/27] applicom: Auto-load applicom module when device opened Alan Cox
2009-04-06 16:33 ` [PATCH 11/27] cyclades: Auto-load cyclades " Alan Cox
2009-04-06 16:33 ` [PATCH 12/27] specialix: Auto-load specialix " Alan Cox
2009-04-06 16:33 ` [PATCH 13/27] usb: Auto-load cdc_acm " Alan Cox
2009-04-06 16:33 ` [PATCH 14/27] riscom8: Auto-load riscom8 " Alan Cox
2009-04-06 16:33 ` [PATCH 15/27] ucc: Fix leaky error path Alan Cox
2009-04-06 16:33 ` [PATCH 16/27] isicom: isicom kref leak fix Alan Cox
2009-04-06 16:34 ` [PATCH 17/27] tty: moxa, fix refcounting in moxa_poll_port Alan Cox
2009-04-06 16:34 ` [PATCH 18/27] mxser: remove tty_port_tty_get from mxser_check_modem_status Alan Cox
2009-04-06 16:34 ` [PATCH 19/27] jsm: define init function as __devinit Alan Cox
2009-04-06 16:34 ` [PATCH 20/27] jsm: Fix the return variable and removing the unused retval Alan Cox
2009-04-06 16:34 ` [PATCH 21/27] mux: fix build problem Alan Cox
2009-04-06 16:34 ` [PATCH 22/27] icom: remove unused variables Alan Cox
2009-04-06 16:35 ` [PATCH 23/27] cdc-acm: zydas 1602 identifier needed Alan Cox
2009-04-06 16:35 ` [PATCH 24/27] tty: pl2303 needs identifiers for Siemens S81 as well as EF81 Alan Cox
2009-04-06 16:35 ` Alan Cox [this message]
2009-04-06 16:35 ` [PATCH 26/27] rio: addition has higher precedence than ?: Alan Cox
2009-04-06 16:35 ` [PATCH 27/27] 8250: Fix warning Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090406163517.12934.81586.stgit@t61.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®