* [PATCH] rtc-tx4939: Drop IRQF_SHARED
@ 2009-04-06 16:50 Atsushi Nemoto
2009-04-06 17:10 ` [rtc-linux] " Alessandro Zummo
2009-04-07 13:16 ` Atsushi Nemoto
0 siblings, 2 replies; 4+ messages in thread
From: Atsushi Nemoto @ 2009-04-06 16:50 UTC (permalink / raw)
To: Alessandro Zummo; +Cc: rtc-linux, linux-kernel
IRQF_SHARED should be used with IRQF_DISABLED. This RTC have dedicated
irq line so there is no reason to use IRQF_SHARED.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
drivers/rtc/rtc-tx4939.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c
index 4ee4857..69085d9 100644
--- a/drivers/rtc/rtc-tx4939.c
+++ b/drivers/rtc/rtc-tx4939.c
@@ -261,7 +261,7 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev)
tx4939_rtc_cmd(pdata->rtcreg, TX4939_RTCCTL_COMMAND_NOP);
if (devm_request_irq(&pdev->dev, irq, tx4939_rtc_interrupt,
- IRQF_DISABLED | IRQF_SHARED,
+ IRQF_DISABLED,
pdev->name, &pdev->dev) < 0) {
return -EBUSY;
}
--
1.5.6.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [rtc-linux] [PATCH] rtc-tx4939: Drop IRQF_SHARED
2009-04-06 16:50 [PATCH] rtc-tx4939: Drop IRQF_SHARED Atsushi Nemoto
@ 2009-04-06 17:10 ` Alessandro Zummo
2009-04-07 12:42 ` Atsushi Nemoto
2009-04-07 13:16 ` Atsushi Nemoto
1 sibling, 1 reply; 4+ messages in thread
From: Alessandro Zummo @ 2009-04-06 17:10 UTC (permalink / raw)
To: rtc-linux; +Cc: anemo, Alessandro Zummo, linux-kernel
On Tue, 7 Apr 2009 01:50:33 +0900
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> IRQF_SHARED should be used with IRQF_DISABLED. This RTC have dedicated
> irq line so there is no reason to use IRQF_SHARED.
Is that true for every board this rtc is/will be used on?
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [rtc-linux] [PATCH] rtc-tx4939: Drop IRQF_SHARED
2009-04-06 17:10 ` [rtc-linux] " Alessandro Zummo
@ 2009-04-07 12:42 ` Atsushi Nemoto
0 siblings, 0 replies; 4+ messages in thread
From: Atsushi Nemoto @ 2009-04-07 12:42 UTC (permalink / raw)
To: alessandro.zummo; +Cc: rtc-linux, a.zummo, linux-kernel
On Mon, 6 Apr 2009 19:10:53 +0200, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> > IRQF_SHARED should be used with IRQF_DISABLED. This RTC have dedicated
> > irq line so there is no reason to use IRQF_SHARED.
>
> Is that true for every board this rtc is/will be used on?
Yes. This RTC is internal device of TX4939 SoC and its irq line is
hardwired to SoC's interrupt controller. At least TX4939 uses
dedicated irq number for the RTC and I believe all future SoC (if
possible) will follow.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtc-tx4939: Drop IRQF_SHARED
2009-04-06 16:50 [PATCH] rtc-tx4939: Drop IRQF_SHARED Atsushi Nemoto
2009-04-06 17:10 ` [rtc-linux] " Alessandro Zummo
@ 2009-04-07 13:16 ` Atsushi Nemoto
1 sibling, 0 replies; 4+ messages in thread
From: Atsushi Nemoto @ 2009-04-07 13:16 UTC (permalink / raw)
To: a.zummo; +Cc: rtc-linux, linux-kernel
On Tue, 7 Apr 2009 01:50:33 +0900, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> IRQF_SHARED should be used with IRQF_DISABLED. This RTC have dedicated
> irq line so there is no reason to use IRQF_SHARED.
Oops, the description was wrong: s/should be used/should not be used/.
I will resend with fixed description.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-07 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-06 16:50 [PATCH] rtc-tx4939: Drop IRQF_SHARED Atsushi Nemoto
2009-04-06 17:10 ` [rtc-linux] " Alessandro Zummo
2009-04-07 12:42 ` Atsushi Nemoto
2009-04-07 13:16 ` Atsushi Nemoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®