mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] USB: serial: add FTDI FT4232H ID
@ 2009-04-07  7:49 Luotao Fu
  2009-04-07  8:30 ` Uwe Bonnes
  0 siblings, 1 reply; 4+ messages in thread
From: Luotao Fu @ 2009-04-07  7:49 UTC (permalink / raw)
  To: gregkh; +Cc: linux-usb, linux-kernel, Luotao Fu

add the ID of FT4232H Hi-Speed quad channel serial converter.

Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
---
 drivers/usb/serial/ftdi_sio.c |    1 +
 drivers/usb/serial/ftdi_sio.h |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index ae84c32..08f5c8a 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -668,6 +668,7 @@ static struct usb_device_id id_table_combined [] = {
 	{ USB_DEVICE(DE_VID, WHT_PID) },
 	{ USB_DEVICE(ADI_VID, ADI_GNICE_PID),
 		.driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
+	{ USB_DEVICE(FTDI_VID, FTDI_4232H_PID) },
 	{ },					/* Optional parameter entry */
 	{ }					/* Terminating entry */
 };
diff --git a/drivers/usb/serial/ftdi_sio.h b/drivers/usb/serial/ftdi_sio.h
index daaf63d..e1072b5 100644
--- a/drivers/usb/serial/ftdi_sio.h
+++ b/drivers/usb/serial/ftdi_sio.h
@@ -28,6 +28,7 @@
 #define FTDI_8U232AM_ALT_PID 0x6006 /* FTDI's alternate PID for above */
 #define FTDI_8U2232C_PID 0x6010 /* Dual channel device */
 #define FTDI_232RL_PID  0xFBFA  /* Product ID for FT232RL */
+#define FTDI_4232H_PID 0x6011	/* quad channel hi-speed */
 #define FTDI_RELAIS_PID	0xFA10  /* Relais device from Rudolf Gugler */
 #define FTDI_NF_RIC_VID	0x0DCD	/* Vendor Id */
 #define FTDI_NF_RIC_PID	0x0001	/* Product Id */
-- 
1.6.2.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] USB: serial: add FTDI FT4232H ID
  2009-04-07  7:49 [PATCH] USB: serial: add FTDI FT4232H ID Luotao Fu
@ 2009-04-07  8:30 ` Uwe Bonnes
  2009-04-07  9:03   ` Luotao Fu
  0 siblings, 1 reply; 4+ messages in thread
From: Uwe Bonnes @ 2009-04-07  8:30 UTC (permalink / raw)
  To: Luotao Fu; +Cc: gregkh, linux-usb, linux-kernel

>>>>> "Luotao" == Luotao Fu <l.fu@pengutronix.de> writes:

    Luotao> add the ID of FT4232H Hi-Speed quad channel serial converter.

This probably isn't enough to make the devices work.

The FT2232H and FT4432H are High Speed devices with defaul buffer sizes of
512 bytes. A recieve buffer contains two status bytes and then up to 510
bytes of data against 62 bytes on the old devices.

Bye
-- 
Uwe Bonnes                bon@elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] USB: serial: add FTDI FT4232H ID
  2009-04-07  8:30 ` Uwe Bonnes
@ 2009-04-07  9:03   ` Luotao Fu
  2009-04-07  9:45     ` Uwe Bonnes
  0 siblings, 1 reply; 4+ messages in thread
From: Luotao Fu @ 2009-04-07  9:03 UTC (permalink / raw)
  To: Uwe Bonnes; +Cc: Luotao Fu, gregkh, linux-usb, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Tue, Apr 07, 2009 at 10:30:52AM +0200, Uwe Bonnes wrote:
> >>>>> "Luotao" == Luotao Fu <l.fu@pengutronix.de> writes:
> 
>     Luotao> add the ID of FT4232H Hi-Speed quad channel serial converter.
> 
> This probably isn't enough to make the devices work.
> 
> The FT2232H and FT4432H are High Speed devices with defaul buffer sizes of
> 512 bytes. A recieve buffer contains two status bytes and then up to 510
> bytes of data against 62 bytes on the old devices.

Shame on me. I did only check whether the device with its four channels are
registered. Since the chip is built-in on our board and I still need some
additional libraries to check the devices connected to it. I haven't done any
function tests still. Will keep an eye on this. Sounds that it could be a little
hairy then. Afais the PID 6001 is e.g. shared by common/high speed devices. I
didn't grab deeper in the ftdi code, probably it'll be some way to work around
this.

cheers
Luotao Fu
-- 
Pengutronix e.K.                           | Dipl.-Ing. Luotao Fu        |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] USB: serial: add FTDI FT4232H ID
  2009-04-07  9:03   ` Luotao Fu
@ 2009-04-07  9:45     ` Uwe Bonnes
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Bonnes @ 2009-04-07  9:45 UTC (permalink / raw)
  To: Luotao Fu; +Cc: Uwe Bonnes, gregkh, linux-usb, linux-kernel

>>>>> "Luotao" == Luotao Fu <l.fu@pengutronix.de> writes:

    Luotao> On Tue, Apr 07, 2009 at 10:30:52AM +0200, Uwe Bonnes wrote:
    >> >>>>> "Luotao" == Luotao Fu <l.fu@pengutronix.de> writes:
    >> 
    Luotao> add the ID of FT4232H Hi-Speed quad channel serial converter.
    >>  This probably isn't enough to make the devices work.
    >> 
    >> The FT2232H and FT4432H are High Speed devices with defaul buffer
    >> sizes of 512 bytes. A recieve buffer contains two status bytes and
    >> then up to 510 bytes of data against 62 bytes on the old devices.

    Luotao> Shame on me. I did only check whether the device with its four
    Luotao> channels are registered. Since the chip is built-in on our board
    Luotao> and I still need some additional libraries to check the devices
    Luotao> connected to it. I haven't done any function tests still. Will
    Luotao> keep an eye on this. Sounds that it could be a little hairy
    Luotao> then. Afais the PID 6001 is e.g. shared by common/high speed
    Luotao> devices. I didn't grab deeper in the ftdi code, probably it'll
    Luotao> be some way to work around this.

For libusb access, some work for the H-Type chips has already been don in
libftdi (www.intra2net.com/en/developer/libftdi/)

-- 
Uwe Bonnes                bon@elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-04-07  9:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-07  7:49 [PATCH] USB: serial: add FTDI FT4232H ID Luotao Fu
2009-04-07  8:30 ` Uwe Bonnes
2009-04-07  9:03   ` Luotao Fu
2009-04-07  9:45     ` Uwe Bonnes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®