Re: 2.6.30-rc1: invalid opcode with call trace

[Ingo Molnar <mingo@elte.hu>]

* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > I too have an async hang/crash, on an old-style SCSI (aic7xxx) box 
> > - hang log attached below.
> > [...]
> >
> > ( Full bootlog attached below as well - i'm sending the config as a 
> >   reply as this mail is close to lkml size limits already. )
> 
> Config attached.
> 
>  known bad  : v2.6.29-9854-gd508afb
>  known good : v2.6.29
> 
> Suspected commit introducing the regression:
> 
>  9710794: async: remove the temporary (2.6.29) "async is off by default" code
> 
> (i'll now try a revert of this.)

The revert of 9710794 (see below) brings the box back to life again.

	Ingo

----------------->
>From daac36664613a70cb3cfef5d6111f1008751c7cb Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 8 Apr 2009 08:52:44 +0200
Subject: [PATCH] Revert "async: remove the temporary (2.6.29) "async is off by default" code"

This reverts commit 9710794383ee5008d67f1a6613a4717bf6de47bc.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/async.c |   18 +++++++++++++-----
 1 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/kernel/async.c b/kernel/async.c
index 968ef94..f565891 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -49,7 +49,6 @@ asynchronous and synchronous parts of the kernel.
 */
 
 #include <linux/async.h>
-#include <linux/bug.h>
 #include <linux/module.h>
 #include <linux/wait.h>
 #include <linux/sched.h>
@@ -388,11 +387,20 @@ static int async_manager_thread(void *unused)
 
 static int __init async_init(void)
 {
-	async_enabled =
-		!IS_ERR(kthread_run(async_manager_thread, NULL, "async/mgr"));
-
-	WARN_ON(!async_enabled);
+	if (async_enabled)
+		if (IS_ERR(kthread_run(async_manager_thread, NULL,
+				       "async/mgr")))
+			async_enabled = 0;
 	return 0;
 }
 
+static int __init setup_async(char *str)
+{
+	async_enabled = 1;
+	return 1;
+}
+
+__setup("fastboot", setup_async);
+
+
 core_initcall(async_init);