From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 3/5] tracing/events: add rcu locking around trace event prints
Date: Wed, 15 Apr 2009 22:18:33 -0400 [thread overview]
Message-ID: <20090416021928.467656424@goodmis.org> (raw)
In-Reply-To: <20090416021830.556671772@goodmis.org>
[-- Attachment #1: 0003-tracing-events-add-rcu-locking-around-trace-event-p.patch --]
[-- Type: text/plain, Size: 1210 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
Some trace events need to have a way to print out data that his
allocated, but will be freed later. Using a function that can allocate
memory, and free it with call_rcu, can be useful.
This patch adds rcu locking around the print part of the TRACE_EVENT
macro to facilitate this.
Reported-by: Theodore Tso <tytso@mit.edu>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/ftrace.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
index 60c5323..6fb06bd 100644
--- a/include/trace/ftrace.h
+++ b/include/trace/ftrace.h
@@ -62,7 +62,9 @@
*
* field = (typeof(field))entry;
*
+ * rcu_read_lock();
* ret = trace_seq_printf(s, <TP_printk> "\n");
+ * rcu_read_unlock();
* if (!ret)
* return TRACE_TYPE_PARTIAL_LINE;
*
@@ -99,7 +101,9 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags) \
\
field = (typeof(field))entry; \
\
+ rcu_read_lock(); \
ret = trace_seq_printf(s, #call ": " print); \
+ rcu_read_unlock(); \
if (!ret) \
return TRACE_TYPE_PARTIAL_LINE; \
\
--
1.6.2.1
--
next prev parent reply other threads:[~2009-04-16 2:20 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 2:18 [PATCH 0/5] [GIT PULL] updates for tip Steven Rostedt
2009-04-16 2:18 ` [PATCH 1/5] ftrace: use module notifier for function tracer Steven Rostedt
2009-04-16 15:36 ` Frederic Weisbecker
2009-04-16 15:53 ` Steven Rostedt
2009-04-17 11:44 ` Steven Rostedt
2009-04-19 11:25 ` Rusty Russell
2009-04-20 13:57 ` Steven Rostedt
2009-04-21 5:15 ` Rusty Russell
2009-04-21 13:13 ` Steven Rostedt
2009-04-21 13:58 ` Ingo Molnar
2009-04-21 17:51 ` Tim Abbott
2009-04-21 18:17 ` Steven Rostedt
2009-04-21 18:47 ` Tim Abbott
2009-04-22 9:16 ` Ingo Molnar
2009-04-22 22:20 ` Tim Abbott
2009-04-22 22:57 ` Masami Hiramatsu
2009-04-23 19:40 ` Anders Kaseorg
2009-04-23 19:57 ` Mathieu Desnoyers
2009-04-23 22:31 ` Tim Abbott
2009-04-24 3:11 ` Masami Hiramatsu
2009-04-23 20:06 ` Masami Hiramatsu
2009-04-16 2:18 ` [PATCH 2/5] tracing/events: add startup tests for events Steven Rostedt
2009-04-16 8:39 ` [PATCH] tracing: add #include <linux/delay.h> to fix build failure in test_work() Ingo Molnar
2009-04-16 14:08 ` Steven Rostedt
2009-04-17 0:30 ` Ingo Molnar
2009-04-16 15:41 ` [PATCH 2/5] tracing/events: add startup tests for events Frederic Weisbecker
2009-04-16 15:51 ` Steven Rostedt
2009-04-16 16:02 ` Frederic Weisbecker
2009-04-16 2:18 ` Steven Rostedt [this message]
2009-04-17 14:08 ` [PATCH 3/5] tracing/events: add rcu locking around trace event prints Steven Rostedt
2009-04-17 15:20 ` Jeremy Fitzhardinge
2009-04-17 15:42 ` Steven Rostedt
2009-04-17 23:53 ` Jeremy Fitzhardinge
2009-04-17 16:18 ` Theodore Tso
2009-04-17 16:32 ` Jeremy Fitzhardinge
2009-04-17 16:41 ` Steven Rostedt
2009-05-07 2:10 ` Steven Rostedt
2009-05-07 11:32 ` Ingo Molnar
2009-05-07 13:10 ` Steven Rostedt
2009-04-16 2:18 ` [PATCH 4/5] tracing/events/ring-buffer: expose format of ring buffer headers to users Steven Rostedt
2009-04-16 2:18 ` [PATCH 5/5] tracing: add saved_cmdlines file to show cached task comms Steven Rostedt
2009-04-16 15:54 ` Frederic Weisbecker
2009-04-16 15:58 ` Steven Rostedt
2009-04-16 16:05 ` Frederic Weisbecker
2009-04-16 9:51 ` [PATCH 0/5] [GIT PULL] updates for tip Ingo Molnar
2009-04-16 9:53 ` Ingo Molnar
2009-04-16 13:52 ` Steven Rostedt
2009-04-16 16:12 ` Ingo Molnar
2009-04-16 16:22 ` Steven Rostedt
2009-04-17 0:29 ` Ingo Molnar
2009-04-16 16:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416021928.467656424@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome