mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] AFS: Guard afs_file_readpage_read_complete() definition with CONFIG_AFS_FSCACHE
@ 2009-04-17 11:56 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2009-04-17 11:56 UTC (permalink / raw)
  To: torvalds, akpm; +Cc: linux-kernel, Matt Kraai, David Howells

From: Matt Kraai <kraai@ftbfs.org>

If CONFIG_AFS_FSCACHE is not defined, the following warning is displayed when
fs/afs/file.c is compiled:

 fs/afs/file.c:111: warning: ‘afs_file_readpage_read_complete’ defined but not used

This occurs because all calls to this function are guarded by
CONFIG_AFS_FSCACHE.  Thus, guard its definition as well.

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/afs/file.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/fs/afs/file.c b/fs/afs/file.c
index 7a1d942..0149dab 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -102,6 +102,7 @@ int afs_release(struct inode *inode, struct file *file)
 	return 0;
 }
 
+#ifdef CONFIG_AFS_FSCACHE
 /*
  * deal with notification that a page was read from the cache
  */
@@ -117,6 +118,7 @@ static void afs_file_readpage_read_complete(struct page *page,
 		SetPageUptodate(page);
 	unlock_page(page);
 }
+#endif
 
 /*
  * AFS read page from file, directory or symlink


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-17 11:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-17 11:56 [PATCH] AFS: Guard afs_file_readpage_read_complete() definition with CONFIG_AFS_FSCACHE David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®