From: David Miller <davem@davemloft.net>
To: divy@chelsio.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
swise@opengridcomputing.com
Subject: Re: [PATCH 2.6.30 2/4] cxgb3: fix workqueue flush issues
Date: Mon, 20 Apr 2009 02:08:19 -0700 (PDT) [thread overview]
Message-ID: <20090420.020819.234015726.davem@davemloft.net> (raw)
In-Reply-To: <20090417222117.8504.11164.stgit@speedy5>
From: Divy Le Ray <divy@chelsio.com>
Date: Fri, 17 Apr 2009 15:21:17 -0700
> The fatal error task can be scheduled while processing an offload packet
> in NAPI context when the connection handle is bogus. this can race
> with the ports being brought down and the cxgb3 workqueue being flushed.
> Stop napi processing before flushing the work queue.
>
> The ULP drivers (iSCSI, iWARP) might also schedule a task on keventd_wk
> while releasing a connection handle (cxgb3_offload.c::cxgb3_queue_tid_release()).
> The driver however does not flush any work on keventd_wq while being unloaded.
> This patch also fixes this.
>
> Also call cancel_delayed_work_sync in place of the the deprecated
> cancel_rearming_delayed_workqueue.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
Applied.
prev parent reply other threads:[~2009-04-20 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 22:21 Divy Le Ray
2009-04-20 9:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420.020819.234015726.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®