mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tim Abbott <tabbott@MIT.EDU>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Anders Kaseorg <andersk@MIT.EDU>, Waseem Daher <wdaher@MIT.EDU>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Andi Kleen <andi@firstfloor.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Jeff Arnold <jbarnold@MIT.EDU>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jon Masters <jonathan@jonmasters.org>
Subject: Re: [PATCH v2 0/4] Add support for compiling with -ffunction-sections -fdata-sections
Date: Mon, 20 Apr 2009 20:18:26 -0700	[thread overview]
Message-ID: <20090420201826.7c1f7f06@infradead.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0904201730590.2199@localhost.localdomain>

On Mon, 20 Apr 2009 17:35:32 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Mon, 20 Apr 2009, Tim Abbott wrote:
> > 
> > I assume you're only worried about toolchain problems for people
> > who are actually using the -ffunction-sections option.  Would it
> > help if the -ffunction-sections compilation option were marked as
> > experimental until proven otherwise?
> 
> The thing is, people will enable them, and then maybe the compiler 
> _appears_ to work, and things don't boot, and people spend tons of
> time chasing down somethign that just turns out to be a tools issue
> and not a kernel issue at all. And nobody happens to realize that
> what's up is that the person who reported the regression had enabled
> an experimental feature.
> 
> > If you're not willing to merge even an experimental option for 
> > -ffunction-sections, would you at least be willing to merge the
> > first three patches in the patch series?  Compiling with
> > -ffunction-sections would not be supported by the mainline kernel,
> > so any toolchain issues with it would not be your problem.  But any
> > vendor that wants to take advantage of -ffunction-sections would
> > still be able to use it without having to maintain 300 lines of
> > scattered changes to the kernel.
> 
> Are there any advantages outside of the size things?

we can probably drop a ton of ifdefs...


an alternative approach would be to have a special build target that
uses this, but makes a 2nd vmlinux, and then runs a diff on the symbols
against the regular one... and finds which functions got dropped.
Some patient soul can then go about and stick in ifdefs and stuff...

(or delete the totally not-used-by-anyone functions entirely)


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  parent reply	other threads:[~2009-04-21  3:16 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-05 23:14 Tim Abbott
2009-04-05 23:14 ` [PATCH v2 1/4] Make section names compatible " Tim Abbott
2009-04-05 23:14   ` [PATCH v2 2/4] modpost: Check the section flags, not name, to catch missing "ax"/"aw" Tim Abbott
2009-04-05 23:14     ` [PATCH v2 3/4] modpost: Support objects with more than 64k sections Tim Abbott
2009-04-05 23:14       ` [PATCH v2 4/4] x86: Add an option to compile with -ffunction-sections -fdata-sections Tim Abbott
2009-04-08  0:34 ` [PATCH v2 0/4] Add support for compiling " Tim Abbott
2009-04-08  5:22   ` Rusty Russell
2009-04-20 20:26   ` Tim Abbott
2009-04-20 23:40     ` Linus Torvalds
2009-04-21  0:26       ` Tim Abbott
2009-04-21  0:35         ` Linus Torvalds
2009-04-21  1:25           ` H. Peter Anvin
2009-04-21  1:49             ` Denys Vlasenko
2009-04-21  3:18           ` Arjan van de Ven [this message]
2009-04-21  3:26             ` Anders Kaseorg
2009-04-21 10:26             ` Andi Kleen
2009-04-21  6:01           ` Tim Abbott
2009-04-21 10:24           ` Andi Kleen
2009-04-23 20:48           ` [PATCH v3 0/3] " Tim Abbott
2009-04-23 20:49             ` [PATCH v3 1/3] Make section names compatible " Tim Abbott
2009-04-23 20:49               ` [PATCH v3 2/3] modpost: Check the section flags, not name, to catch missing "ax"/"aw" Tim Abbott
2009-04-23 20:49                 ` [PATCH v3 3/3] modpost: Support objects with more than 64k sections Tim Abbott
2009-04-24  0:16               ` [PATCH v3 1/3] Make section names compatible with -ffunction-sections -fdata-sections Paul Mundt
2009-04-24 17:23               ` Sam Ravnborg
2009-04-26  2:10                 ` Tim Abbott
2009-04-26  2:10                   ` [PATCH 01/15] Add new HEAD_TEXT_SECTION macro Tim Abbott
2009-04-26  2:10                     ` [PATCH 02/15] xtensa: convert to use __HEAD and HEAD_TEXT macros Tim Abbott
2009-04-26  2:10                       ` [PATCH 03/15] alpha: " Tim Abbott
2009-04-26  2:10                         ` [PATCH 04/15] frv: convert frv " Tim Abbott
2009-04-26  2:11                           ` [PATCH 05/15] arm: convert " Tim Abbott
2009-04-26  2:11                             ` [PATCH 06/15] ia64: " Tim Abbott
2009-04-26  2:11                               ` [PATCH 07/15] m32r: " Tim Abbott
2009-04-26  2:11                                 ` [PATCH 08/15] m68k: " Tim Abbott
2009-04-26  2:11                                   ` [PATCH 09/15] mn10300: " Tim Abbott
2009-04-26  2:11                                     ` [PATCH 10/15] powerpc: " Tim Abbott
2009-04-26  2:11                                       ` [PATCH 11/15] s390: " Tim Abbott
2009-04-26  2:11                                         ` [PATCH 12/15] sh: " Tim Abbott
2009-04-26  2:11                                           ` [PATCH 13/15] sparc: " Tim Abbott
2009-04-26  2:11                                             ` [PATCH 14/15] x86: " Tim Abbott
2009-04-26  2:11                                               ` [PATCH 15/15] modpost: convert modpost to use HEAD_TEXT_SECTION macro Tim Abbott
2009-04-26 11:30                                                 ` Sam Ravnborg
2009-04-26 22:18                                                   ` Anders Kaseorg
2009-04-26 11:28                                               ` [PATCH 14/15] x86: convert to use __HEAD and HEAD_TEXT macros Sam Ravnborg
2009-04-26 16:40                                               ` Linus Torvalds
2009-04-26 17:12                                                 ` Linus Torvalds
2009-04-26 18:34                                                   ` Sam Ravnborg
2009-04-26 18:56                                                     ` Linus Torvalds
2009-04-26 19:23                                                       ` Sam Ravnborg
2009-04-26 21:07                                                         ` [PATCH] x86: beautify vmlinux_64.lds.S Sam Ravnborg
2009-04-27  4:54                                                           ` [tip:x86/kbuild] " tip-bot for Sam Ravnborg
2009-04-27  4:59                                                         ` [PATCH 14/15] x86: convert to use __HEAD and HEAD_TEXT macros Ingo Molnar
2009-04-27  6:42                                                           ` Sam Ravnborg
2009-04-27  7:19                                                             ` Ingo Molnar
2009-04-27  7:37                                                               ` Sam Ravnborg
2009-04-26 20:50                                                       ` Andi Kleen
2009-04-27  3:47                                                       ` Ingo Molnar
2009-04-30 10:39                                                   ` [tip:x86/kbuild] x86: boot/compressed/vmlinux.lds.S: fix build of bzImage with 64 bit compiler tip-bot for Sam Ravnborg
2009-04-30 14:52                                                     ` H. Peter Anvin
2009-04-30 15:09                                                       ` Sam Ravnborg
2009-04-30 16:29                                                         ` H. Peter Anvin
2009-04-30 17:52                                                           ` Sam Ravnborg
2009-04-30 19:02                                                             ` H. Peter Anvin
2009-04-26 11:24                                             ` [PATCH 13/15] sparc: convert to use __HEAD and HEAD_TEXT macros Sam Ravnborg
2009-04-26 11:24                                           ` [PATCH 12/15] sh: " Sam Ravnborg
2009-04-26 11:23                                         ` [PATCH 11/15] s390: " Sam Ravnborg
2009-04-26 11:23                                       ` [PATCH 10/15] powerpc: " Sam Ravnborg
2009-04-26 11:22                                     ` [PATCH 09/15] mn10300: " Sam Ravnborg
2009-04-26 11:22                                   ` [PATCH 08/15] m68k: " Sam Ravnborg
2009-04-26 11:21                                 ` [PATCH 07/15] m32r: " Sam Ravnborg
2009-04-28  3:34                                   ` Hirokazu Takata
2009-04-26 11:21                               ` [PATCH 06/15] ia64: " Sam Ravnborg
2009-04-26 11:19                             ` [PATCH 05/15] arm: " Sam Ravnborg
2009-04-27 16:46                               ` Tim Abbott
2009-04-27 17:00                                 ` Russell King
2009-04-27 17:06                                 ` Linus Torvalds
2009-04-27 17:29                                   ` Luck, Tony
2009-04-28  8:56                                   ` Ralf Baechle
2009-04-26 11:16                           ` [PATCH 04/15] frv: convert frv " Sam Ravnborg
2009-04-26 11:15                         ` [PATCH 03/15] alpha: convert " Sam Ravnborg
2009-04-26 11:13                       ` [PATCH 02/15] xtensa: " Sam Ravnborg
2009-04-26 16:29                     ` [PATCH 01/15] Add new HEAD_TEXT_SECTION macro Linus Torvalds
2009-04-26  2:42                   ` [PATCH v3 1/3] Make section names compatible with -ffunction-sections -fdata-sections Paul Mundt
2009-04-26  9:15                     ` Sam Ravnborg
2009-04-26  9:20                     ` [PATCH] kbuild: fix comment in modpost.c Sam Ravnborg
2009-04-26 17:28                       ` Tim Abbott
2009-04-26  9:09                   ` [PATCH v3 1/3] Make section names compatible with -ffunction-sections -fdata-sections Sam Ravnborg
2009-04-26 21:53                     ` Tim Abbott
2009-04-26 13:09                 ` Rusty Russell
2009-04-24  0:14             ` [PATCH v3 0/3] Add support for compiling " Paul Mundt
2009-04-24 14:19             ` Masami Hiramatsu
2009-04-24 15:32               ` Tim Abbott
2009-04-25  1:49                 ` Masami Hiramatsu
2009-04-21  1:05       ` [PATCH v2 0/4] " Denys Vlasenko
2009-04-21  5:50       ` Rusty Russell
2009-04-22 12:47         ` Paul Mundt
2009-04-21 14:02 ` Américo Wang
2009-04-21 17:40   ` Anders Kaseorg
2009-04-22 11:38     ` Masami Hiramatsu
2009-04-22 17:13       ` Tim Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090420201826.7c1f7f06@infradead.org \
    --to=arjan@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=andersk@MIT.EDU \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=jbarnold@MIT.EDU \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sfr@canb.auug.org.au \
    --cc=tabbott@MIT.EDU \
    --cc=torvalds@linux-foundation.org \
    --cc=vda.linux@googlemail.com \
    --cc=wdaher@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome