mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrea Righi <righi.andrea@gmail.com>,
	randy.dunlap@oracle.com, Carl Henrik Lunde <chlunde@ping.uio.no>,
	Jens Axboe <jens.axboe@oracle.com>,
	eric.rannaud@gmail.com, Balbir Singh <balbir@linux.vnet.ibm.com>,
	fernando@oss.ntt.co.jp, dradford@bluehost.com,
	Gui@smtp1.linux-foundation.org, agk@sourceware.org,
	subrata@linux.vnet.ibm.com, Paul Menage <menage@google.com>,
	akpm@linux-foundation.org, containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, dave@linux.vnet.ibm.com,
	matt@bluehost.com, roberto@unbit.it, ngupta@google.com
Subject: Re: [PATCH 9/9] ext3: do not throttle metadata and journal IO
Date: Wed, 22 Apr 2009 21:22:54 -0400	[thread overview]
Message-ID: <20090423012254.GZ15541@mit.edu> (raw)
In-Reply-To: <20090423090535.ec419269.kamezawa.hiroyu@jp.fujitsu.com>

On Thu, Apr 23, 2009 at 09:05:35AM +0900, KAMEZAWA Hiroyuki wrote:
> So, current status is.
> 
>   A. memcg should support dirty_ratio for its own memory reclaim.
>      in plan.
> 
>   B. another cgroup can be implemnted to support cgroup_dirty_limit().
>      But relationship with "A" should be discussed.
>      no plan yet.
> 
>   C. I/O cgroup and bufferred I/O tracking system.
>      Now under patch review.
> 
> And this I/O throttle is mainly for "C" discussion. 

How much testing has been done in terms of whether the I/O throttling
actually works?  Not just, "the kernel doesn't crash", but that where
you have one process generating a large amount of I/O load, in various
different ways, and whether the right things happens?  If so, how has
this been measured?

I'm really concerned that given some of the ways that I/O will "leak"
out --- the via pdflush, swap writeout, etc., that without the rest of
the pieces in place, I/O throttling by itself might not prove to be
very effective.  Sure, if the workload is only doing direct I/O, life
is pretty easy and it shouldn't be hard to throttle the cgroup.

But in the case where there is bufferred I/O, without write
throttling, it's hard to see how well the I/O controller will work in
practice.  In fact, I wouldn't be that surprised if it's possible to
trigger the OOM killer.......

Regards,

						- Ted

  reply	other threads:[~2009-04-23  1:26 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14 20:21 [PATCH 0/9] cgroup: io-throttle controller (v13) Andrea Righi
2009-04-14 20:21 ` [PATCH 1/9] io-throttle documentation Andrea Righi
2009-04-17  1:24   ` KAMEZAWA Hiroyuki
2009-04-17  1:56     ` Li Zefan
2009-04-17 10:25       ` Andrea Righi
2009-04-17 10:41         ` Andrea Righi
2009-04-17 11:35         ` Fernando Luis Vázquez Cao
2009-04-20  9:38         ` Ryo Tsuruta
2009-04-20 15:00           ` Andrea Righi
2009-04-27 10:45             ` Ryo Tsuruta
2009-04-27 12:15               ` Ryo Tsuruta
2009-04-27 21:56               ` Andrea Righi
2009-04-17  7:34     ` Gui Jianfeng
2009-04-17  7:43       ` KAMEZAWA Hiroyuki
2009-04-17  9:29         ` Gui Jianfeng
2009-04-17  9:55     ` Andrea Righi
2009-04-17 17:39   ` Vivek Goyal
2009-04-17 23:12     ` Andrea Righi
2009-04-19 13:42       ` Vivek Goyal
2009-04-19 15:47         ` Andrea Righi
2009-04-20 21:28           ` Vivek Goyal
2009-04-20 22:05             ` Andrea Righi
2009-04-21  1:08               ` Vivek Goyal
2009-04-21  8:37                 ` Andrea Righi
2009-04-21 14:23                   ` Vivek Goyal
2009-04-21 18:29                     ` Vivek Goyal
2009-04-21 21:36                       ` Andrea Righi
2009-04-21 21:28                     ` Andrea Righi
2009-04-19 13:54       ` Vivek Goyal
2009-04-14 20:21 ` [PATCH 2/9] res_counter: introduce ratelimiting attributes Andrea Righi
2009-04-14 20:21 ` [PATCH 3/9] bio-cgroup controller Andrea Righi
2009-04-15  2:15   ` KAMEZAWA Hiroyuki
2009-04-15  9:37     ` Andrea Righi
2009-04-15 12:38       ` Ryo Tsuruta
2009-04-15 13:23         ` Andrea Righi
2009-04-15 23:58           ` KAMEZAWA Hiroyuki
2009-04-16 10:42             ` Andrea Righi
2009-04-16 12:00               ` Ryo Tsuruta
2009-04-17  0:04               ` KAMEZAWA Hiroyuki
2009-04-17  9:44                 ` Andrea Righi
2009-04-15 13:07     ` Andrea Righi
2009-04-16 22:29   ` Andrew Morton
2009-04-17  0:20     ` KAMEZAWA Hiroyuki
2009-04-17  0:44       ` Andrew Morton
2009-04-17  1:44         ` Ryo Tsuruta
2009-04-17  4:15           ` Andrew Morton
2009-04-17  7:48             ` Ryo Tsuruta
2009-04-17  1:50         ` Balbir Singh
2009-04-17  9:40     ` Andrea Righi
2009-04-17  1:49   ` Takuya Yoshikawa
2009-04-17  2:24     ` KAMEZAWA Hiroyuki
2009-04-17  7:22       ` Ryo Tsuruta
2009-04-17  8:00         ` KAMEZAWA Hiroyuki
2009-04-17  8:48           ` KAMEZAWA Hiroyuki
2009-04-17  8:51             ` KAMEZAWA Hiroyuki
2009-04-17 11:27         ` Block I/O tracking (was Re: [PATCH 3/9] bio-cgroup controller) Fernando Luis Vázquez Cao
2009-04-17 22:09           ` Andrea Righi
2009-04-17  7:32     ` [PATCH 3/9] bio-cgroup controller Ryo Tsuruta
2009-04-17 10:22   ` Balbir Singh
2009-04-20 11:35     ` Ryo Tsuruta
2009-04-20 14:56       ` Andrea Righi
2009-04-21 11:39         ` Ryo Tsuruta
2009-04-21 15:31         ` Balbir Singh
2009-04-14 20:21 ` [PATCH 4/9] support checking of cgroup subsystem dependencies Andrea Righi
2009-04-14 20:21 ` [PATCH 5/9] io-throttle controller infrastructure Andrea Righi
2009-04-14 20:21 ` [PATCH 6/9] kiothrottled: throttle buffered (writeback) IO Andrea Righi
2009-04-14 20:21 ` [PATCH 7/9] io-throttle instrumentation Andrea Righi
2009-04-14 20:21 ` [PATCH 8/9] export per-task io-throttle statistics to userspace Andrea Righi
2009-04-14 20:21 ` [PATCH 9/9] ext3: do not throttle metadata and journal IO Andrea Righi
2009-04-17 12:38   ` Theodore Tso
2009-04-17 12:50     ` Jens Axboe
2009-04-17 14:39       ` Andrea Righi
2009-04-21  0:18         ` Theodore Tso
2009-04-21  8:30           ` Andrea Righi
2009-04-21 14:06             ` Theodore Tso
2009-04-21 14:31               ` Andrea Righi
2009-04-21 16:35                 ` Theodore Tso
2009-04-21 17:23                   ` Balbir Singh
2009-04-21 17:46                     ` Theodore Tso
2009-04-21 18:14                       ` Balbir Singh
2009-04-21 19:14                         ` Theodore Tso
2009-04-21 20:49                           ` Andrea Righi
2009-04-22  0:33                             ` KAMEZAWA Hiroyuki
2009-04-22  1:21                               ` KAMEZAWA Hiroyuki
2009-04-22 10:22                                 ` Andrea Righi
2009-04-23  0:05                                   ` KAMEZAWA Hiroyuki
2009-04-23  1:22                                     ` Theodore Tso [this message]
2009-04-23  2:54                                       ` KAMEZAWA Hiroyuki
2009-04-23  4:35                                         ` Theodore Tso
2009-04-23  4:58                                           ` Andrew Morton
2009-04-23  5:37                                             ` KAMEZAWA Hiroyuki
2009-04-23  9:44                                           ` Andrea Righi
2009-04-23 12:17                                             ` Theodore Tso
2009-04-23 12:27                                               ` Theodore Tso
2009-04-23 21:13                                               ` Andrea Righi
2009-04-24  0:26                                                 ` KAMEZAWA Hiroyuki
2009-04-24  5:14                                           ` Balbir Singh
2009-04-23 10:03                                     ` Andrea Righi
2009-04-22  3:30                           ` Balbir Singh
2009-04-24 15:10               ` Balbir Singh
2009-04-16 22:24 ` [PATCH 0/9] cgroup: io-throttle controller (v13) Andrew Morton
2009-04-17  9:37   ` Andrea Righi
2009-04-30 13:20 ` Alan D. Brunelle
2009-05-01 11:11   ` Andrea Righi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423012254.GZ15541@mit.edu \
    --to=tytso@mit.edu \
    --cc=Gui@smtp1.linux-foundation.org \
    --cc=agk@sourceware.org \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=chlunde@ping.uio.no \
    --cc=containers@lists.linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=dradford@bluehost.com \
    --cc=eric.rannaud@gmail.com \
    --cc=fernando@oss.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@bluehost.com \
    --cc=menage@google.com \
    --cc=ngupta@google.com \
    --cc=randy.dunlap@oracle.com \
    --cc=righi.andrea@gmail.com \
    --cc=roberto@unbit.it \
    --cc=subrata@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome