mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] atomic: Only take lock when the counter drops to zero on UP as well (v2)
@ 2009-04-23 13:51 Jan Blunck
  0 siblings, 0 replies; only message in thread
From: Jan Blunck @ 2009-04-23 13:51 UTC (permalink / raw)
  To: linux-kernel; +Cc: npiggin, paulmck, akpm

_atomic_dec_and_lock() should not unconditionally take the lock before
calling atomic_dec_and_test() in the UP case. For consistency reasons it
should behave exactly like in the SMP case.
    
Besides that this works around the problem that with CONFIG_DEBUG_SPINLOCK
this spins in __spin_lock_debug() if the lock is already taken even if the
counter doesn't drop to 0.

Signed-off-by: Jan Blunck <jblunck@suse.de>
---
diff --git a/lib/dec_and_lock.c b/lib/dec_and_lock.c
index a65c314..e73822a 100644
--- a/lib/dec_and_lock.c
+++ b/lib/dec_and_lock.c
@@ -19,11 +19,10 @@
  */
 int _atomic_dec_and_lock(atomic_t *atomic, spinlock_t *lock)
 {
-#ifdef CONFIG_SMP
 	/* Subtract 1 from counter unless that drops it to 0 (ie. it was 1) */
 	if (atomic_add_unless(atomic, -1, 1))
 		return 0;
-#endif
+
 	/* Otherwise do it the slow way */
 	spin_lock(lock);
 	if (atomic_dec_and_test(atomic))

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-23 13:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-23 13:51 [PATCH] atomic: Only take lock when the counter drops to zero on UP as well (v2) Jan Blunck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®