[PATCH] net/ipv6/tcp_ipv6.c: fix sparse warnings

[PATCH] net/ipv6/tcp_ipv6.c: fix sparse warnings

[H Hartley Sweeten]

Fix the following sparse warnings in net/ipv6/tcp_ipv6.c.

  warning: symbol 'tcp6_gro_receive' was not declared. Should it be static?
  warning: symbol 'tcp6_gro_complete' was not declared. Should it be static?

Both symbols are exported but not referenced anywhere outside of
this source file. Remove the exports and make the functions static.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 4b5aa18..d391555 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -941,7 +941,7 @@ static int tcp_v6_gso_send_check(struct sk_buff *skb)
 	return 0;
 }
 
-struct sk_buff **tcp6_gro_receive(struct sk_buff **head, struct sk_buff *skb)
+static struct sk_buff **tcp6_gro_receive(struct sk_buff **head, struct sk_buff *skb)
 {
 	struct ipv6hdr *iph = ipv6_hdr(skb);
 
@@ -961,9 +961,8 @@ struct sk_buff **tcp6_gro_receive(struct sk_buff **head, struct sk_buff *skb)
 
 	return tcp_gro_receive(head, skb);
 }
-EXPORT_SYMBOL(tcp6_gro_receive);
 
-int tcp6_gro_complete(struct sk_buff *skb)
+static int tcp6_gro_complete(struct sk_buff *skb)
 {
 	struct ipv6hdr *iph = ipv6_hdr(skb);
 	struct tcphdr *th = tcp_hdr(skb);
@@ -974,7 +973,6 @@ int tcp6_gro_complete(struct sk_buff *skb)
 
 	return tcp_gro_complete(skb);
 }
-EXPORT_SYMBOL(tcp6_gro_complete);
 
 static void tcp_v6_send_response(struct sk_buff *skb, u32 seq, u32 ack, u32 win,
 				 u32 ts, struct tcp_md5sig_key *key, int rst) 

Re: [PATCH] net/ipv6/tcp_ipv6.c: fix sparse warnings

[David Miller]

From: "H Hartley Sweeten" <hartleys@visionengravers.com>
Date: Wed, 22 Apr 2009 20:35:39 -0400

> Fix the following sparse warnings in net/ipv6/tcp_ipv6.c.
> 
>   warning: symbol 'tcp6_gro_receive' was not declared. Should it be static?
>   warning: symbol 'tcp6_gro_complete' was not declared. Should it be static?
> 
> Both symbols are exported but not referenced anywhere outside of
> this source file. Remove the exports and make the functions static.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

1) Please post networking patches with netdev@vger.kernel.org
   at least CC:'d

2) Your email client corrupted this patch, making it not apply
   properly.

Please fix these details up and resubmit your patch, thanks!