From: "J. Bruce Fields" <bfields@fieldses.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/sunrpc/svc_xprt.c: fix sparse warnings
Date: Tue, 28 Apr 2009 13:01:13 -0400 [thread overview]
Message-ID: <20090428170113.GT17891@fieldses.org> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090165F128@mi8nycmail19.Mi8.com>
On Wed, Apr 22, 2009 at 08:18:19PM -0400, H Hartley Sweeten wrote:
> Fix the following sparse warnings in net/sunrpc/svc_xprt.c.
>
> warning: symbol 'svc_recv' was not declared. Should it be static?
> warning: symbol 'svc_drop' was not declared. Should it be static?
> warning: symbol 'svc_send' was not declared. Should it be static?
> warning: symbol 'svc_close_all' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Thanks, applied for 2.6.31.--b.
>
> ---
>
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index c200d92..f200393 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -11,6 +11,7 @@
> #include <net/sock.h>
> #include <linux/sunrpc/stats.h>
> #include <linux/sunrpc/svc_xprt.h>
> +#include <linux/sunrpc/svcsock.h>
>
> #define RPCDBG_FACILITY RPCDBG_SVCXPRT
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2009-04-28 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 0:18 H Hartley Sweeten
2009-04-28 17:01 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428170113.GT17891@fieldses.org \
--to=bfields@fieldses.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®