mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] net/sunrpc/svc_xprt.c: fix sparse warnings
@ 2009-04-23  0:18 H Hartley Sweeten
  2009-04-28 17:01 ` J. Bruce Fields
  0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2009-04-23  0:18 UTC (permalink / raw)
  To: linux-kernel

Fix the following sparse warnings in net/sunrpc/svc_xprt.c.

  warning: symbol 'svc_recv' was not declared. Should it be static?
  warning: symbol 'svc_drop' was not declared. Should it be static?
  warning: symbol 'svc_send' was not declared. Should it be static?
  warning: symbol 'svc_close_all' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index c200d92..f200393 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -11,6 +11,7 @@
 #include <net/sock.h>
 #include <linux/sunrpc/stats.h>
 #include <linux/sunrpc/svc_xprt.h>
+#include <linux/sunrpc/svcsock.h>
 
 #define RPCDBG_FACILITY	RPCDBG_SVCXPRT
  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/sunrpc/svc_xprt.c: fix sparse warnings
  2009-04-23  0:18 [PATCH] net/sunrpc/svc_xprt.c: fix sparse warnings H Hartley Sweeten
@ 2009-04-28 17:01 ` J. Bruce Fields
  0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2009-04-28 17:01 UTC (permalink / raw)
  To: H Hartley Sweeten; +Cc: linux-kernel

On Wed, Apr 22, 2009 at 08:18:19PM -0400, H Hartley Sweeten wrote:
> Fix the following sparse warnings in net/sunrpc/svc_xprt.c.
> 
>   warning: symbol 'svc_recv' was not declared. Should it be static?
>   warning: symbol 'svc_drop' was not declared. Should it be static?
>   warning: symbol 'svc_send' was not declared. Should it be static?
>   warning: symbol 'svc_close_all' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Thanks, applied for 2.6.31.--b.

> 
> ---
> 
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index c200d92..f200393 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -11,6 +11,7 @@
>  #include <net/sock.h>
>  #include <linux/sunrpc/stats.h>
>  #include <linux/sunrpc/svc_xprt.h>
> +#include <linux/sunrpc/svcsock.h>
>  
>  #define RPCDBG_FACILITY	RPCDBG_SVCXPRT
>   
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-28 17:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-23  0:18 [PATCH] net/sunrpc/svc_xprt.c: fix sparse warnings H Hartley Sweeten
2009-04-28 17:01 ` J. Bruce Fields

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®