From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
Chuck Ebbert <cebbert@redhat.com>,
Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk,
Vitaly Mayatskikh <v.mayatskih@gmail.com>,
Thomas Tuttle <ttuttle@google.com>,
Matt Mackall <mpm@selenic.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [patch 08/18] pagemap: require aligned-length, non-null reads of /proc/pid/pagemap
Date: Wed, 06 May 2009 13:30:18 -0700 [thread overview]
Message-ID: <20090506203129.431125090@blue.kroah.org> (raw)
In-Reply-To: <20090506203353.GA14624@kroah.com>
[-- Attachment #1: pagemap-require-aligned-length-non-null-reads-of-proc-pid-pagemap.patch --]
[-- Type: text/plain, Size: 1287 bytes --]
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
commit 0816178638c15ce5472d39d771a96860dff4141a upstream.
The intention of commit aae8679b0ebcaa92f99c1c3cb0cd651594a43915
("pagemap: fix bug in add_to_pagemap, require aligned-length reads of
/proc/pid/pagemap") was to force reads of /proc/pid/pagemap to be a
multiple of 8 bytes, but now it allows to read 0 bytes, which actually
puts some data to user's buffer. According to POSIX, if count is zero,
read() should return zero and has no other results.
Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc: Thomas Tuttle <ttuttle@google.com>
Acked-by: Matt Mackall <mpm@selenic.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
fs/proc/task_mmu.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -665,6 +665,10 @@ static ssize_t pagemap_read(struct file
goto out_task;
ret = 0;
+
+ if (!count)
+ goto out_task;
+
mm = get_task_mm(task);
if (!mm)
goto out_task;
next prev parent reply other threads:[~2009-05-06 20:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090506203010.615363711@blue.kroah.org>
2009-05-06 20:33 ` [patch 00/18] 2.6.27.23-stable review Greg KH
2009-05-06 20:30 ` [patch 01/18] drm/i915: add support for G41 chipset Greg KH
2009-05-06 20:30 ` [patch 02/18] virtio-rng: Remove false BUG for spurious callbacks Greg KH
2009-05-06 20:30 ` [patch 03/18] USB: Unusual Device support for Gold MP3 Player Energy Greg KH
2009-05-06 20:30 ` [patch 04/18] forcedeth: Fix resume from hibernation regression Greg KH
2009-05-06 20:30 ` [patch 05/18] b43: Poison RX buffers Greg KH
2009-05-06 20:30 ` [patch 06/18] b43: Refresh RX poison on buffer recycling Greg KH
2009-05-06 20:30 ` [patch 07/18] kbuild: fix Module.markers permission error under cygwin Greg KH
2009-05-06 20:30 ` Greg KH [this message]
2009-05-06 20:30 ` [patch 09/18] PCI quirk: disable MSI on VIA VT3364 chipsets Greg KH
2009-05-06 20:30 ` [patch 10/18] x86/PCI: dont call e820_all_mapped with -1 in the mmconfig case Greg KH
2009-05-06 20:30 ` [patch 11/18] ACPI: Revert conflicting workaround for BIOS w/ mangled PRT entries Greg KH
2009-05-06 20:30 ` [patch 12/18] MIPS: CVE-2009-0029: Enable syscall wrappers Greg KH
2009-05-06 20:30 ` [patch 13/18] USB: serial: fix lifetime and locking problems Greg KH
2009-05-06 20:30 ` [patch 14/18] clockevents: prevent endless loop in tick_handle_periodic() Greg KH
2009-05-06 20:30 ` [patch 15/18] Ignore madvise(MADV_WILLNEED) for hugetlbfs-backed regions Greg KH
2009-05-06 20:30 ` [patch 16/18] mv643xx_eth: 64bit mib counter read fix Greg KH
2009-05-06 20:30 ` [patch 17/18] proc: avoid information leaks to non-privileged processes Greg KH
2009-05-06 20:30 ` [patch 18/18] rndis_wlan: fix initialization order for workqueue&workers Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506203129.431125090@blue.kroah.org \
--to=gregkh@suse.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cavokz@gmail.com \
--cc=cebbert@redhat.com \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=eteo@redhat.com \
--cc=jake@lwn.net \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=mpm@selenic.com \
--cc=rbranco@la.checkpoint.com \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ttuttle@google.com \
--cc=tytso@mit.edu \
--cc=v.mayatskih@gmail.com \
--cc=w@1wt.eu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®