From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Shaohua Li <shaohua.li@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86 MCE: shut up lockdep warning
Date: Fri, 8 May 2009 21:11:01 +0200 [thread overview]
Message-ID: <20090508191101.GB23223@one.firstfloor.org> (raw)
In-Reply-To: <1241771697.11251.194.camel@twins>
> So was this a genuine bug in your code? The patch suggests it was.
No I think it was false. See my earlier email.
The higher level cpu_add_remove_lock makes sure that there is never
an interrupt when the code is running process context.
So Ingo's patch shuts off lockdep, but it's overkill and not really
needed. It would be better if there was some way to express
the dependency on cpu_add_remove_lock, but I'm not sure
that can be expressed in lockdep.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-05-08 19:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 3:47 Shaohua Li
2009-05-08 6:45 ` Andi Kleen
2009-05-08 9:10 ` Ingo Molnar
2009-05-08 9:37 ` Andi Kleen
2009-05-08 12:14 ` Shaohua Li
2009-05-08 8:17 ` Hidetoshi Seto
2009-05-08 8:28 ` [PATCH] x86 MCE: yet another " Hidetoshi Seto
2009-05-08 9:07 ` [tip:x86/urgent] x86: MCE: make cmci_discover_lock irq-safe tip-bot for Hidetoshi Seto
2009-05-08 8:34 ` [PATCH] x86 MCE: shut up lockdep warning Peter Zijlstra
2009-05-08 19:11 ` Andi Kleen [this message]
2009-05-08 9:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508191101.GB23223@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®