mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Dmitry Baryshkov <dbaryshkov@gmail.com>
Subject: Re: [PATCH] gpio: max7301: add missing __devexit marking
Date: Mon, 18 May 2009 10:48:23 +0200	[thread overview]
Message-ID: <200905181048.24264.jbe@pengutronix.de> (raw)
In-Reply-To: <1242633428-16460-1-git-send-email-vapier@gentoo.org>

On Montag, 18. Mai 2009, Mike Frysinger wrote:
> The remove member of the spi_driver max7301_driver uses __devexit_p(),
> so the remove function itself should be marked with __devexit.  Even
> more so considering the probe function is marked with __devinit.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Juergen Beisert <j.beisert@pengutronix.de>
> CC: Dmitry Baryshkov <dbaryshkov@gmail.com>
> ---
>  drivers/gpio/max7301.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/max7301.c b/drivers/gpio/max7301.c
> index 3e7f4e0..7b82eaa 100644
> --- a/drivers/gpio/max7301.c
> +++ b/drivers/gpio/max7301.c
> @@ -287,7 +287,7 @@ exit_destroy:
>  	return ret;
>  }
>
> -static int max7301_remove(struct spi_device *spi)
> +static int __devexit max7301_remove(struct spi_device *spi)
>  {
>  	struct max7301 *ts;
>  	int ret;

Acked-by: Juergen Beisert <j.beisert@pengutronix.de>

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

      reply	other threads:[~2009-05-18  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18  7:57 Mike Frysinger
2009-05-18  8:48 ` Juergen Beisert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905181048.24264.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®