* [PATCH] gpio: max7301: add missing __devexit marking
@ 2009-05-18 7:57 Mike Frysinger
2009-05-18 8:48 ` Juergen Beisert
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2009-05-18 7:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Juergen Beisert, Dmitry Baryshkov
The remove member of the spi_driver max7301_driver uses __devexit_p(),
so the remove function itself should be marked with __devexit. Even
more so considering the probe function is marked with __devinit.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
CC: Juergen Beisert <j.beisert@pengutronix.de>
CC: Dmitry Baryshkov <dbaryshkov@gmail.com>
---
drivers/gpio/max7301.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/max7301.c b/drivers/gpio/max7301.c
index 3e7f4e0..7b82eaa 100644
--- a/drivers/gpio/max7301.c
+++ b/drivers/gpio/max7301.c
@@ -287,7 +287,7 @@ exit_destroy:
return ret;
}
-static int max7301_remove(struct spi_device *spi)
+static int __devexit max7301_remove(struct spi_device *spi)
{
struct max7301 *ts;
int ret;
--
1.6.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] gpio: max7301: add missing __devexit marking
2009-05-18 7:57 [PATCH] gpio: max7301: add missing __devexit marking Mike Frysinger
@ 2009-05-18 8:48 ` Juergen Beisert
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Beisert @ 2009-05-18 8:48 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-kernel, Dmitry Baryshkov
On Montag, 18. Mai 2009, Mike Frysinger wrote:
> The remove member of the spi_driver max7301_driver uses __devexit_p(),
> so the remove function itself should be marked with __devexit. Even
> more so considering the probe function is marked with __devinit.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Juergen Beisert <j.beisert@pengutronix.de>
> CC: Dmitry Baryshkov <dbaryshkov@gmail.com>
> ---
> drivers/gpio/max7301.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/max7301.c b/drivers/gpio/max7301.c
> index 3e7f4e0..7b82eaa 100644
> --- a/drivers/gpio/max7301.c
> +++ b/drivers/gpio/max7301.c
> @@ -287,7 +287,7 @@ exit_destroy:
> return ret;
> }
>
> -static int max7301_remove(struct spi_device *spi)
> +static int __devexit max7301_remove(struct spi_device *spi)
> {
> struct max7301 *ts;
> int ret;
Acked-by: Juergen Beisert <j.beisert@pengutronix.de>
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | Phone: +49-8766-939 228 |
Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-18 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-18 7:57 [PATCH] gpio: max7301: add missing __devexit marking Mike Frysinger
2009-05-18 8:48 ` Juergen Beisert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®