* [PATCH] PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev()
@ 2009-05-19 1:02 Alex Chiang
2009-06-11 18:27 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: Alex Chiang @ 2009-05-19 1:02 UTC (permalink / raw)
To: jbarnes; +Cc: linux-pci, linux-kernel
We always call pci_stop_bus_device before calling pci_destroy_dev.
Since pci_stop_bus_device calls pci_stop_dev, there is no need
for pci_destroy_dev to repeat the call.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/pci/remove.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
index 86503c1..176615e 100644
--- a/drivers/pci/remove.c
+++ b/drivers/pci/remove.c
@@ -32,8 +32,6 @@ static void pci_stop_dev(struct pci_dev *dev)
static void pci_destroy_dev(struct pci_dev *dev)
{
- pci_stop_dev(dev);
-
/* Remove the device from the device lists, and prevent any further
* list accesses from this device */
down_write(&pci_bus_sem);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev()
2009-05-19 1:02 [PATCH] PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev() Alex Chiang
@ 2009-06-11 18:27 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2009-06-11 18:27 UTC (permalink / raw)
To: Alex Chiang; +Cc: linux-pci, linux-kernel
On Mon, 18 May 2009 19:02:38 -0600
Alex Chiang <achiang@hp.com> wrote:
> We always call pci_stop_bus_device before calling pci_destroy_dev.
>
> Since pci_stop_bus_device calls pci_stop_dev, there is no need
> for pci_destroy_dev to repeat the call.
>
> Signed-off-by: Alex Chiang <achiang@hp.com>
> ---
>
> drivers/pci/remove.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
> index 86503c1..176615e 100644
> --- a/drivers/pci/remove.c
> +++ b/drivers/pci/remove.c
> @@ -32,8 +32,6 @@ static void pci_stop_dev(struct pci_dev *dev)
>
> static void pci_destroy_dev(struct pci_dev *dev)
> {
> - pci_stop_dev(dev);
> -
> /* Remove the device from the device lists, and prevent any
> further
> * list accesses from this device */
> down_write(&pci_bus_sem);
Applied to linux-next, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-11 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-19 1:02 [PATCH] PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev() Alex Chiang
2009-06-11 18:27 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®