mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mike@it-loops.com
Cc: buytenh@wantstofly.org, afleming@freescale.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	rjw@sisk.pl
Subject: Re: [PATCH,RFC] gianfar: fix BUG under load after introduction of skb recycling
Date: Mon, 25 May 2009 00:42:58 -0700 (PDT)	[thread overview]
Message-ID: <20090525.004258.82412594.davem@davemloft.net> (raw)
In-Reply-To: <2A79CAF4-334F-4763-82E3-2460377F3078@it-loops.com>

From: Michael Guntsche <mike@it-loops.com>
Date: Sun, 24 May 2009 17:32:05 +0200

> 
> On May 23, 2009, at 13:51, Lennert Buytenhek wrote:
> 
>> Since commit 0fd56bb5be6455d0d42241e65aed057244665e5e ("gianfar:
>> Add support for skb recycling"), gianfar puts skbuffs that are in
>> the rx ring back onto the recycle list as-is in case there was a
>> receive error, but this breaks the following invariant: that all
>> skbuffs on the recycle list have skb->data = skb->head + NET_SKB_PAD.
>>
>>
>> Michael, can you re-test with this version of the patch?
>> Andy, can you see if this is OK with you?
> 
> Hi, I have been running tests with this patch for the last 6 hours and
> had no panics so far.
> So it fixes the issues I am seeing as well.

Since it's now tested, I am applying this to net-2.6 to expedite it's
inclusion into 2.6.30

Thanks.

      reply	other threads:[~2009-05-25  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23 11:51 Lennert Buytenhek
2009-05-24 15:32 ` Michael Guntsche
2009-05-25  7:42   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090525.004258.82412594.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=afleming@freescale.com \
    --cc=buytenh@wantstofly.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike@it-loops.com \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®