From: Michael Guntsche <mike@it-loops.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Andy Fleming <afleming@freescale.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH,RFC] gianfar: fix BUG under load after introduction of skb recycling
Date: Sun, 24 May 2009 17:32:05 +0200 [thread overview]
Message-ID: <2A79CAF4-334F-4763-82E3-2460377F3078@it-loops.com> (raw)
In-Reply-To: <20090523115143.GB1672@mail.wantstofly.org>
On May 23, 2009, at 13:51, Lennert Buytenhek wrote:
> Since commit 0fd56bb5be6455d0d42241e65aed057244665e5e ("gianfar:
> Add support for skb recycling"), gianfar puts skbuffs that are in
> the rx ring back onto the recycle list as-is in case there was a
> receive error, but this breaks the following invariant: that all
> skbuffs on the recycle list have skb->data = skb->head + NET_SKB_PAD.
>
>
> Michael, can you re-test with this version of the patch?
> Andy, can you see if this is OK with you?
Hi, I have been running tests with this patch for the last 6 hours and
had no panics so far.
So it fixes the issues I am seeing as well.
Hope this helps,
Michael
next prev parent reply other threads:[~2009-05-24 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 11:51 Lennert Buytenhek
2009-05-24 15:32 ` Michael Guntsche [this message]
2009-05-25 7:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2A79CAF4-334F-4763-82E3-2460377F3078@it-loops.com \
--to=mike@it-loops.com \
--cc=afleming@freescale.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®