From: Pierre Ossman <pierre@ossman.eu>
To: "Wolfgang Mües" <wolfgang.mues@auerswald.de>
Cc: "David Brownell" <david-b@pacbell.net>,
"Matt Fleming" <matt@console-pimps.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mike Frysinger" <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc_spi: use EILSEQ for possible transmission errors
Date: Mon, 25 May 2009 13:50:12 +0200 [thread overview]
Message-ID: <20090525135012.13be624c@mjolnir.ossman.eu> (raw)
In-Reply-To: <200905251218.18262.wolfgang.mues@auerswald.de>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Mon, 25 May 2009 12:18:18 +0200
Wolfgang Mües <wolfgang.mues@auerswald.de> wrote:
>
> So if this code gets integrated, we can do:
>
> if (command is erase)
> accept erase response codes
> else
> treat erase response codes as transmission errors
>
> Should be no problem...
>
This furthers the layering violation though. I don't remember why
mmc_spi is looking at responses to begin with. It should be up to the
caller to interpret them.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-05-25 11:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 11:24 Wolfgang Mües
2009-05-19 11:29 ` Matt Fleming
2009-05-19 11:47 ` Wolfgang Mües
2009-05-20 7:53 ` Matt Fleming
2009-05-20 4:49 ` David Brownell
2009-05-20 8:35 ` Wolfgang Mües
2009-05-20 9:20 ` David Brownell
2009-05-20 10:08 ` Pierre Ossman
2009-05-21 2:02 ` David Brownell
2009-05-25 9:04 ` Wolfgang Mües
2009-05-25 9:43 ` David Brownell
2009-05-25 10:18 ` Wolfgang Mües
2009-05-25 11:50 ` Pierre Ossman [this message]
2009-05-25 14:59 ` Wolfgang Mües
2009-06-09 18:07 ` Pierre Ossman
2009-06-10 7:29 ` Wolfgang Mües
2009-06-10 7:37 ` Matt Fleming
2009-06-13 10:57 ` Pierre Ossman
2009-05-25 11:48 ` Pierre Ossman
2009-05-20 10:31 ` Wolfgang Mües
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525135012.13be624c@mjolnir.ossman.eu \
--to=pierre@ossman.eu \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=vapier.adi@gmail.com \
--cc=wolfgang.mues@auerswald.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®