* [PATCH 1/2] net/netfilter: make symbol static
@ 2009-05-28 12:45 Hannes Eder
2009-05-28 12:45 ` [PATCH 2/2] net/netfilter: remove redundant variable Hannes Eder
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2009-05-28 12:45 UTC (permalink / raw)
To: netdev; +Cc: netfilter-devel, linux-kernel
Fix this sparse warning:
net/netfilter/nf_log.c:219:17: warning: symbol 'nf_log_sysctl_path' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
net/netfilter/nf_log.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
index beb3731..7511aed 100644
--- a/net/netfilter/nf_log.c
+++ b/net/netfilter/nf_log.c
@@ -216,7 +216,7 @@ static const struct file_operations nflog_file_ops = {
#endif /* PROC_FS */
#ifdef CONFIG_SYSCTL
-struct ctl_path nf_log_sysctl_path[] = {
+static struct ctl_path nf_log_sysctl_path[] = {
{ .procname = "net", .ctl_name = CTL_NET, },
{ .procname = "netfilter", .ctl_name = NET_NETFILTER, },
{ .procname = "nf_log", .ctl_name = CTL_UNNUMBERED, },
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] net/netfilter: remove redundant variable
2009-05-28 12:45 [PATCH 1/2] net/netfilter: make symbol static Hannes Eder
@ 2009-05-28 12:45 ` Hannes Eder
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Eder @ 2009-05-28 12:45 UTC (permalink / raw)
To: netdev; +Cc: netfilter-devel, linux-kernel
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
net/netfilter/nf_log.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
index 7511aed..b584cc2 100644
--- a/net/netfilter/nf_log.c
+++ b/net/netfilter/nf_log.c
@@ -47,7 +47,6 @@ int nf_log_register(u_int8_t pf, struct nf_logger *logger)
mutex_lock(&nf_log_mutex);
if (pf == NFPROTO_UNSPEC) {
- int i;
for (i = NFPROTO_UNSPEC; i < NFPROTO_NUMPROTO; i++)
list_add_tail(&(logger->list[i]), &(nf_loggers_l[i]));
} else {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-28 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-28 12:45 [PATCH 1/2] net/netfilter: make symbol static Hannes Eder
2009-05-28 12:45 ` [PATCH 2/2] net/netfilter: remove redundant variable Hannes Eder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®