From: Sam Ravnborg <sam@ravnborg.org>
To: Cheng Renquan <crq@hera.kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, crquan@gmail.com
Subject: Re: [PATCH] Kbuild: remove extra ifdef/endif of top Makefile
Date: Fri, 5 Jun 2009 23:56:11 +0200 [thread overview]
Message-ID: <20090605215611.GG29008@uranus.ravnborg.org> (raw)
In-Reply-To: <1243324987-17840-1-git-send-email-crq@hera.kernel.org>
On Tue, May 26, 2009 at 04:03:07PM +0800, Cheng Renquan wrote:
> From: Cheng Renquan <crq@kernel.org>
>
> The GNU make's origin function know undefined variable well,
> so the outer ifdef/endif is unneeded.
>
> I've checked the minimal requirements from Documentation/Changes
> is GNU make 3.79.1, and that version of GNU make has support of
> origin function already, so now it's safe to kill the outer
> conditional checking, without upgrading the minimal requirements.
Applied with V2 of your description,
Sam
prev parent reply other threads:[~2009-06-05 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 8:03 Cheng Renquan
2009-06-05 21:56 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605215611.GG29008@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=crq@hera.kernel.org \
--cc=crquan@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®