From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <cl@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>
Cc: Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
rusty@rustcorp.com.au, davem@davemloft.net
Subject: Re: [this_cpu_xx 04/11] Use this_cpu ops for network statistics
Date: Mon, 8 Jun 2009 22:54:06 +0200 [thread overview]
Message-ID: <20090608205406.GB13343@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0906081649020.12271@gentwo.org>
* Christoph Lameter <cl@linux-foundation.org> wrote:
> On Mon, 8 Jun 2009, Robin Holt wrote:
>
> > > + this_cpu_inc((net)->ct.stat->count)
> >
> > Why not put this on one line?
> > #define NF_CT_STAT_INC_ATOMIC(net, count) this_cpu_inc((net)->ct.stat->count)
>
> Would be more than 78 characters in a line.
I think you can ignore such types of warnings in general. I think
checkpatch should be silent up to 90 chars or so, if there's not
more than say 3 tabs in that line. (if there's a lot of tabs that
means the indentation level is wrong.)
Ingo
next prev parent reply other threads:[~2009-06-08 20:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 19:18 [this_cpu_xx 00/11] Introduce this_cpu_xx operations cl
2009-06-05 19:18 ` [this_cpu_xx 01/11] Introduce this_cpu_ptr() and generic this_cpu_* operations cl
2009-06-10 5:12 ` Tejun Heo
2009-06-11 15:10 ` Christoph Lameter
2009-06-12 2:09 ` Tejun Heo
2009-06-12 14:18 ` Christoph Lameter
2009-06-17 8:09 ` Tejun Heo
2009-06-17 8:19 ` Tejun Heo
2009-06-17 18:41 ` Christoph Lameter
2009-06-18 1:08 ` Tejun Heo
2009-06-18 3:01 ` Rusty Russell
2009-06-05 19:18 ` [this_cpu_xx 02/11] Use this_cpu operations for SNMP statistics cl
2009-06-05 19:18 ` [this_cpu_xx 03/11] Use this_cpu operations for NFS statistics cl
2009-06-05 19:18 ` [this_cpu_xx 04/11] Use this_cpu ops for network statistics cl
2009-06-08 11:27 ` Robin Holt
2009-06-08 20:49 ` Christoph Lameter
2009-06-08 20:54 ` Ingo Molnar [this message]
2009-06-05 19:18 ` [this_cpu_xx 05/11] this_cpu_ptr: Straight transformations cl
2009-06-05 19:18 ` [this_cpu_xx 06/11] Eliminate get/put_cpu cl
2009-06-05 19:34 ` Dan Williams
2009-06-09 14:02 ` Sosnowski, Maciej
2009-06-05 19:18 ` [this_cpu_xx 07/11] xfs_icsb_modify_counters does not need "cpu" variable cl
2009-06-05 19:22 ` Christoph Hellwig
2009-06-05 19:36 ` Christoph Lameter
2009-06-05 19:18 ` [this_cpu_xx 08/11] Use this_cpu_ptr in crypto subsystem cl
2009-06-05 19:18 ` [this_cpu_xx 09/11] X86 optimized this_cpu operations cl
2009-06-05 19:18 ` [this_cpu_xx 10/11] Use this_cpu ops for vm statistics cl
2009-06-05 19:18 ` [this_cpu_xx 11/11] RCU: Use this_cpu operations cl
2009-06-10 17:42 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608205406.GB13343@elte.hu \
--to=mingo@elte.hu \
--cc=apw@canonical.com \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®