From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
Christoph Hellwig <hch@infradead.org>,
Rik van Riel <riel@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Theodore Tso <tytso@mit.edu>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Zhaolei <zhaolei@cn.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Jason Baron <jbaron@redhat.com>,
Jiaying Zhang <jiayingz@google.com>,
Tom Zanussi <tzanussi@gmail.com>,
Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH 00/11] [GIT PULL] more updates for the tag format
Date: Wed, 10 Jun 2009 11:26:44 +0200 [thread overview]
Message-ID: <20090610092644.GA20889@elte.hu> (raw)
In-Reply-To: <20090610054206.510574695@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Ingo,
>
> Please pull the latest tip/tracing/event-print-format tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/tracing/event-print-format
>
>
> Li Zefan (1):
> tracing/events: convert block trace points to TRACE_EVENT(), fix
>
> Steven Rostedt (10):
> tracing: add nsec2sec print formats
> tracing: convert lockdep lock_acquired trace point to use nsec2usec tag
> tracing: add major and minor tags for print format
> tracing: use << to print < instead of \<
> tracing: convert the block trace points to use the new tag format
> tracing: add test for strings in event tag format
> tracing: add func and symfunc to tag format
> tracing: check full name for field
> tracing: update sample code with new tag format
> tracing: move '>' to out of macros and into print statement
>
> ----
> include/linux/blktrace_api.h | 4 +-
> include/linux/ftrace_event.h | 3 +-
> include/trace/events/block.h | 101 +++------
> include/trace/events/irq.h | 8 +-
> include/trace/events/kmem.h | 12 +-
> include/trace/events/lockdep.h | 8 +-
> include/trace/ftrace.h | 2 +-
> kernel/trace/trace_output.c | 2 +-
> kernel/trace/trace_output.h | 4 +
> kernel/trace/trace_read_binary.c | 304 +++++++++++++++++++++++-----
> samples/trace_events/trace-events-sample.c | 21 ++-
> samples/trace_events/trace-events-sample.h | 66 ++++++
> 12 files changed, 399 insertions(+), 136 deletions(-)
Hm, that's way too much back and forth really - trivial typo fixes,
build failure, etc. This is really a 'oh, the merge window is
coming' last minute scrambling and we dont want to mess up the
squeaky-clean tracing tree history be messed up with this.
Frederic also expressed worries about the tag format. Could we have
a wider buy-in for this format?
I've separated these bits into tip:tracing/ftrace, and kept
tip:tracing/core on a pre-print-formats state (going back 8
commits), so that upstream merging of the other bits does not get
held up.
Could we try a cleaner, bisectable, consiously built up version of
these final tracing/core..tracing/ftrace please? I think we can -
the rest of the tree is clean. Please do a exact-same-content rebase
so that the merge back gets obvious and that the testing we've
injected does not get invalidated?
Ingo
next prev parent reply other threads:[~2009-06-10 9:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 5:42 Steven Rostedt
2009-06-10 5:42 ` [PATCH 01/11] tracing/events: convert block trace points to TRACE_EVENT(), fix Steven Rostedt
2009-06-10 5:42 ` [PATCH 02/11] tracing: add nsec2sec print formats Steven Rostedt
2009-06-10 5:42 ` [PATCH 03/11] tracing: convert lockdep lock_acquired trace point to use nsec2usec tag Steven Rostedt
2009-06-10 5:42 ` [PATCH 04/11] tracing: add major and minor tags for print format Steven Rostedt
2009-06-10 5:42 ` [PATCH 05/11] tracing: use << to print < instead of \< Steven Rostedt
2009-06-10 5:42 ` [PATCH 06/11] tracing: convert the block trace points to use the new tag format Steven Rostedt
2009-06-10 5:42 ` [PATCH 07/11] tracing: add test for strings in event " Steven Rostedt
2009-06-10 5:42 ` [PATCH 08/11] tracing: add func and symfunc to " Steven Rostedt
2009-06-10 7:48 ` Frederic Weisbecker
2009-06-10 12:55 ` Steven Rostedt
2009-06-10 5:42 ` [PATCH 09/11] tracing: check full name for field Steven Rostedt
2009-06-10 5:42 ` [PATCH 10/11] tracing: update sample code with new tag format Steven Rostedt
2009-06-10 5:42 ` [PATCH 11/11] tracing: move > to out of macros and into print statement Steven Rostedt
2009-06-10 9:26 ` Ingo Molnar [this message]
2009-06-10 11:11 ` [PATCH 00/11] [GIT PULL] more updates for the tag format Frédéric Weisbecker
2009-06-10 13:01 ` Theodore Tso
2009-06-10 13:49 ` Steven Rostedt
2009-06-10 14:39 ` Mathieu Desnoyers
2009-06-10 15:21 ` Steven Rostedt
2009-06-10 16:03 ` Theodore Tso
2009-06-10 16:17 ` Steven Rostedt
2009-06-11 13:03 ` Christoph Hellwig
2009-06-11 15:47 ` Theodore Tso
2009-06-11 17:14 ` Frederic Weisbecker
2009-06-11 19:20 ` Theodore Tso
2009-06-19 8:14 ` [BUG] bugs in jbd2_dev_to_name() (was Re: [PATCH 00/11] [GIT PULL] more updates for the tag format) Li Zefan
2009-06-19 12:32 ` Theodore Tso
2009-06-22 1:36 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610092644.GA20889@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=compudj@krystal.dyndns.org \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tytso@mit.edu \
--cc=tzanussi@gmail.com \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome